Page MenuHomePhabricator

In the DonationInterface form, handle case in which a user clicks on an employer from the dropdown, then types the name of an employer not on the list
Closed, ResolvedPublic2 Estimated Story Points

Description

If the user does this, the hidden form field retains the id of the employer the user clicked on, which is probably not what we want, I think?

DoD:
If a user types something that is not in the list, we don't save any data about employer.

Event Timeline

XenoRyet set the point value for this task to 2.Jul 6 2020, 8:54 PM

Change 610140 had a related patch set uploaded (by Jgleeson; owner: Jgleeson):
[mediawiki/extensions/DonationInterface@master] Reset employer_id each time a new search starts

https://gerrit.wikimedia.org/r/610140

I +2ed this but I'm a little concerned about the opposite case where someone accidentally types after entering their correct employer. I wonder if the kind of locked styling would help with. I played with it for 10 minutes but I don't want to go too far out of scope.

Change 610140 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Reset employer_id each time a new search starts

https://gerrit.wikimedia.org/r/610140