Change 614722 had a related patch set uploaded (by Ostrzyciel; owner: Ostrzyciel):
[mediawiki/core@master] ServiceOptions: implement Config interface

https://gerrit.wikimedia.org/r/614722

• ServiceOptions implements basically the \Config interface, except it doesn't.

I've accidentally stumbled upon a situation where this actually matters, see this patch for more info. Implementing \Config would allow for sensible passing of options for subservices.

On that note, I also thought about making the system a little bit more strongly coupled, without relying on coding conventions. Instead of each class that uses ServiceOptions having a CONSTRUCTOR_OPTIONS constant, such class would implement an interface that would provide a static method getConstructorOptions(). This way the builder wouldn't have to know anything about service's constants, it'd just pass the class name to ServiceOptions (or something) and the rest would be done there.

• The key list is needed twice, in the builder and in the constructor. I don't have any suggestions on how to fix this though.

That could probably be fixed with generics, if PHP was a sensible language. Something like:

class ServiceOptions<T> where T implements ServiceOptionListProvider {
  ...
}

class SomeService implements ServiceOptionListProvider {
  public static function getConstructorOptions() { ... }

  public function __construct( ServiceOptions<SomeService> $options ) { ... }
}

new SomeService( new ServiceOptions<SomeService>( $config /* or whatever */ ) );

Idk, maybe someone will find the idea interesting. Or maybe PHP will get generics some day. Or maybe it could be done with Phan annotations.

Change 614722 abandoned by Ostrzyciel:
[mediawiki/core@master] ServiceOptions: implement Config interface

Reason:
This was indeed quite misguided. I'll try a different approach.

https://gerrit.wikimedia.org/r/614722