Page MenuHomePhabricator

Call to a member function getSourceName() on null, when deploying entity source config to wikidata clients
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

MediaWiki version: 1.35.0-wmf.39

While deploying a config change https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/569259
which was then reverted https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/608838
https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/608839 is the replacement
as part of T254315

Only happened on commonswiki

message
Call to a member function getSourceName() on null

Impact

Notes

Details

Request ID
9ef65fad-d1f2-463d-a8ec-ed66e5a3cac6
Request URL
https://commons.wikimedia.org/wiki/Special:EntityData/M2428908.json?revision=395341637
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/Content/EntityContentFactory.php(139): Wikibase\Repo\Content\EntityContentFactory->entityNotFromLocalEntitySource(Wikibase\MediaInfo\DataModel\MediaInfoId)
#1 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/Content/EntityContentFactory.php(120): Wikibase\Repo\Content\EntityContentFactory->getTitleForFederatedId(Wikibase\MediaInfo\DataModel\MediaInfoId)
#2 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/Store/TypeDispatchingEntityTitleStoreLookup.php(44): Wikibase\Repo\Content\EntityContentFactory->getTitleForId(Wikibase\MediaInfo\DataModel\MediaInfoId)
#3 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/Api/ResultBuilder.php(334): Wikibase\Repo\Store\TypeDispatchingEntityTitleStoreLookup->getTitleForId(Wikibase\MediaInfo\DataModel\MediaInfoId)
#4 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/Api/ResultBuilder.php(298): Wikibase\Repo\Api\ResultBuilder->addPageInfoToRecord(array, Wikibase\Lib\Store\EntityRevision)
#5 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(420): Wikibase\Repo\Api\ResultBuilder->addEntityRevision(string, Wikibase\Lib\Store\EntityRevision)
#6 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(448): Wikibase\Repo\LinkedData\EntityDataSerializationService->generateApiResult(Wikibase\Lib\Store\EntityRevision, ApiFormatJson)
#7 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(173): Wikibase\Repo\LinkedData\EntityDataSerializationService->getApiSerialization(Wikibase\Lib\Store\EntityRevision, ApiFormatJson)
#8 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(527): Wikibase\Repo\LinkedData\EntityDataSerializationService->getSerializedData(string, Wikibase\Lib\Store\EntityRevision, NULL, array, NULL)
#9 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(276): Wikibase\Repo\LinkedData\EntityDataRequestHandler->showData(WebRequest, OutputPage, string, Wikibase\MediaInfo\DataModel\MediaInfoId, integer)
#10 /srv/mediawiki/php-1.35.0-wmf.39/extensions/Wikibase/repo/includes/Specials/SpecialEntityData.php(157): Wikibase\Repo\LinkedData\EntityDataRequestHandler->handleRequest(string, WebRequest, OutputPage)
#11 /srv/mediawiki/php-1.35.0-wmf.39/includes/specialpage/SpecialPage.php(580): Wikibase\Repo\Specials\SpecialEntityData->execute(string)
#12 /srv/mediawiki/php-1.35.0-wmf.39/includes/specialpage/SpecialPageFactory.php(635): SpecialPage->run(string)
#13 /srv/mediawiki/php-1.35.0-wmf.39/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#14 /srv/mediawiki/php-1.35.0-wmf.39/includes/MediaWiki.php(986): MediaWiki->performRequest()
#15 /srv/mediawiki/php-1.35.0-wmf.39/includes/MediaWiki.php(543): MediaWiki->main()
#16 /srv/mediawiki/php-1.35.0-wmf.39/index.php(53): MediaWiki->run()
#17 /srv/mediawiki/php-1.35.0-wmf.39/index.php(46): wfIndexMain()
#18 /srv/mediawiki/w/index.php(3): require(string)
#19 {main}

Event Timeline

Change 569260 had a related patch set uploaded (by Addshore; owner: WMDE-leszek):
[operations/mediawiki-config@master] Commons: Define entity sources configuration

https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/ /569260

Change 569260 merged by jenkins-bot:
[operations/mediawiki-config@master] Commons: Define entity sources configuration

https://gerrit.wikimedia.org/r/569260

Change 609644 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[operations/mediawiki-config@master] Revert "Commons: Define entity sources configuration"

https://gerrit.wikimedia.org/r/609644

Change 609644 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Commons: Define entity sources configuration"

https://gerrit.wikimedia.org/r/609644

Mentioned in SAL (#wikimedia-operations) [2020-07-07T07:27:45Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:609644|Revert "Commons: Define entity sources configuration" (T256906, T256907, T256909, T254315, T257266)]] (duration: 00m 53s)

Mentioned in SAL (#wikimedia-operations) [2020-07-07T07:31:05Z] <lucaswerkmeister-wmde@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:609644|Revert "Commons: Define entity sources configuration" (T256906, T256907, T256909, T254315, T257266)]] (forgot to git rebase so the last sync was a no-op) (duration: 00m 56s)

Change 609987 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] Commons: Define entity sources configuration (take 2)

https://gerrit.wikimedia.org/r/609987

Change 609987 merged by jenkins-bot:
[operations/mediawiki-config@master] Commons: Define entity sources configuration (take 2)

https://gerrit.wikimedia.org/r/609987