Page MenuHomePhabricator
Create Task
Maniphest T256918

Review dead code around TOTP scratch tokens
Closed, ResolvedPublic
Actions

Description

Follow-up from the token problem found at T244308: PHP Notice: Undefined offset: 8 from TOTPKey.php.

I did a bit of analysis and came up with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/+/582945.

Please review and/or adjust accordingly so that similar bugs can be avoided in the future, and so that we have a better understanding of what this is meant to do.

Details

SubjectRepoBranchLines +/-
TOTPKey: Use foreach instead of for-i-length and remove dead codemediawiki/extensions/OATHAuthmaster+20 -25
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jul 1 2020, 8:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2020, 8:41 PM
gerritbot added a comment.Jul 1 2020, 8:41 PM

Change 582945 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/OATHAuth@master] TOTPKey: Use foreach instead of for-i-length and remove dead code

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/ /582945

gerritbot added a project: Patch-For-Review.Jul 1 2020, 8:41 PM
• eprodromou edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Jul 7 2020, 8:21 PM
• eprodromou moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.
• eprodromou edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Team Workboards (Clinic Duty Team).Jul 7 2020, 8:25 PM
Krinkle renamed this task from Figure out what the dead code around scratch tokens is meant to do to Review dead code around TOTP scratch tokens.Aug 12 2020, 3:50 AM
Krinkle triaged this task as Medium priority.
gerritbot added a comment.Mar 29 2021, 11:59 PM

Change 582945 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@master] TOTPKey: Use foreach instead of for-i-length and remove dead code

https://gerrit.wikimedia.org/r/582945

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).Mar 30 2021, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 30 2021, 12:10 AM
• AMooney removed a project: Platform Team Workboards (External Code Reviews).Apr 14 2021, 7:44 PM
Krinkle closed this task as Resolved.Apr 14 2021, 9:24 PM
Krinkle assigned this task to Jdforrester-WMF.
Krinkle edited projects, added Platform Engineering; removed MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).

Thanks James. Re-tagging PE for future query analysis since afaik this is code PE commissioned (not external or for other teams, it was meant to be internal maintenance).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL