Page MenuHomePhabricator

mediawiki-fresnel-patch-docker should set jenkins as reviewer
Closed, DeclinedPublic

Description

Looking at patch sets where mediawiki-fresnel-patch-docker is the first jenkins job adding a commen it is looking like this:

 jenkins-bot
    Added to cc:  jenkins-bot
 jenkins-bot
     This patch might be adding a page load cost.
[...] 
 jenkins-bot
     Moved from cc to reviewer:  jenkins-bot
 jenkins-bot Verified +2
      Main test build succeeded.

It would be better when the first comment adds jenkins directly as reviewer and avoid the later moving. That would make the comment section a bit smaller.

From [https://gerrit.wikimedia.org/r/c/mediawiki/core/+/608683]

Event Timeline

hashar subscribed.

The first comment comes from the coverage job which merely write a message. The gerrit review command was:

gerrit.review.--project.mediawiki/core.--message.This patch might be adding a page load cost.

- mediawiki-fresnel-patch-docker https://integration.wikimedia.org/ci/job/mediawiki-fresnel-patch-docker/24738/consoleFull : FAILURE in 1m 46s
.608683,2

It does not send any label vote and is thus simply a comment hence why it is originally put on cc.

The next one is the tests succeeding which came with a Verified +2 vote. That makes jenkins-bot hence why it is moved from cc to reviewer.

We have task to flag those comments as being autogenerated and thus hidden by default, I guess that will address it. T48148