Page MenuHomePhabricator

Deprecate Skin::generateDebugHTML
Closed, ResolvedPublic

Description

This adds unnecessary indirection to a static method and should be added unconditionally to skins using SkinMustache without the skin developer having to think about it.

Acceptance criteria

  • Update SkinTemplate to call MWDebug::getHTMLDebugLog() directly
  • Mark Skin::getHTMLDebugLog as deprecated
  • Update SkinMustache to include the text getHTMLDebugLog in html-printtail

Event Timeline

Ammarpad claimed this task.Jul 2 2020, 12:42 PM

Change 609203 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] T256927

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /609203

Change 609404 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Vector@master] Call MWDebug::getHTMLDebugLog() directly

https://gerrit.wikimedia.org/r/609404

Change 609487 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate Skin::generateDebugHTML()

https://gerrit.wikimedia.org/r/609487

Change 609404 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Call MWDebug::getHTMLDebugLog() directly

https://gerrit.wikimedia.org/r/609404

Jdlrobson closed this task as Resolved.Jul 6 2020, 6:26 PM
Jdlrobson updated the task description. (Show Details)

Change 609487 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Skin::generateDebugHTML()

https://gerrit.wikimedia.org/r/609487