Choosing a wrong host with transfer.py produces an "ERROR: The specified source path X doesn't exist on Y"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jcrespo
	Jul 2 2020, 9:57 AM

Description

I been bitten by this misleading error message a few times. If I run:

$ transfer.py cumin2001.eqiad.wmnet:/home/jynus/tendril/web/index.php db1077.eqiad.wmnet:/home/jynus
2020-07-02 09:49:57  ERROR: The specified source path /home/jynus/tendril/web/index.php doesn't exist on cumin2001.eqiad.wmnet

But my mistake was to run it with cumin2001.eqiad.wmnet instead of cumin2001.codfw.wmnet, I chose the wrong host.

Probably the logic was that because checking for existence failed, it assumed that the file/dir didn't exist, rather than the host didn't exist. Could cumin execution be parsed to mark it was a host error rather than a path error, on both source and target? Or maybe test for host validity beforehand?

Details

	Subject	Repo	Branch	Lines +/-
	Transferer.py: Produce correct error when users try with a wrong host.	operations/software/transferpy	master	+23 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	jcrespo	T246435 Create or improve a tool for monitoring or automating tasks for Wikimedia databases
Resolved	Privacybatm	T248256 GSoC 2020 Proposal: Improve the framework to transfer files over the LAN
Resolved	Privacybatm	T256951 Choosing a wrong host with transfer.py produces an "ERROR: The specified source path X doesn't exist on Y"

Event Timeline

jcrespo created this task.Jul 2 2020, 9:57 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2020, 9:57 AM

jcrespo moved this task from Triage to GSOC2020 on the DBA board.Jul 2 2020, 9:57 AM

jcrespo added a parent task: T248256: GSoC 2020 Proposal: Improve the framework to transfer files over the LAN.

Parsing cumin output seems to be a better idea, let me check the output of cumin in this kind of cases.

Change in opinion :D Our code has specific tests for all the cases, So I will make one for host validity also, that way it will be aligned to the existing code.

Change 609136 had a related patch set uploaded (by Privacybatm; owner: Privacybatm):
[operations/software/transferpy@master] Transferer.py: Produce correct error when users try with a wrong host.

https://gerrit.wikimedia.org/r/c/operations/software/transferpy/ /609136

gerritbot added a project: Patch-For-Review.Jul 2 2020, 11:21 AM

Change 609136 merged by Jcrespo:
[operations/software/transferpy@master] Transferer.py: Produce correct error when users try with a wrong host.

https://gerrit.wikimedia.org/r/609136

Maintenance_bot removed a project: Patch-For-Review.Jul 3 2020, 5:10 PM