Page MenuHomePhabricator

Gerrit commit message body is always wrapped with MS Edge
Closed, DeclinedPublic

Description

Gerrit commit message body is always wrapped with MS Edge 44.17763.1.0 and does not respect any line feeds.

Event Timeline

I'm lacking access to MS Edge. Could you please post a screenshot?

I'm lacking access to MS Edge. Could you please post a screenshot?

Sure.

The commit message:

commit.PNG (372×718 px, 17 KB)

And as it is shown with Gerrit:

gerrit.PNG (756×1 px, 97 KB)

If I understood CSS properly, the wrapping rule comes from the first rule in:

:host([pre]) span {
    white-space: var(--linked-text-white-space, pre-wrap);
    word-wrap: var(--linked-text-word-wrap, break-word);
}

And Microsoft Edge should support white-space: pre-wrap according to https://caniuse.com/#feat=mdn-css_properties_white-space_pre-wrap , and it supports var() as well. We would need to look at the dom/css rule applied to the element.

There are some demos at https://developer.mozilla.org/en-US/docs/Web/CSS/white-space :)

This is unlikely to be ever solved, the recommendation is to use Chromium. Firefox works well as well in my experience, there are some time issues with it but upstream is happy to fix them when we report them.

For Microsoft Edge, it is based on Chromium, so I can imagine a more recent version of Edge would fix the issue encountered. Else you would have to switch to Chromium or Firefox.

so I can imagine a more recent version of Edge would fix the issue

I’ve forgotten this task, sorry. I can confirm that a more recent Edge solved this issue.