Page MenuHomePhabricator

Visual diff containing signature node throws error, doesn't render the signature
Closed, ResolvedPublic

Description

  1. Open VE in a namespace that supports signatures
  2. Type ~~~~ to get a signature node
  3. Open the visual diff

4a. Observe there is an error in the console
4b. Observe no signature is rendered.

Event Timeline

Change 609143 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] GeneratedContentNode: Don't try to render if model is detached

https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/ /609143

Esanders renamed this task from Visual diff containing signature node throws error to Visual diff containing signature node throws error, doesn't render the signature.Jul 2 2020, 1:17 PM
Esanders updated the task description. (Show Details)

Change 609147 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] MWSignatureNode: Use template's rendering hash object

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/ /609147

Change 609143 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] GeneratedContentNode: Don't try to render if model is detached

https://gerrit.wikimedia.org/r/609143

Change 609147 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWSignatureNode: Use template's rendering hash object

https://gerrit.wikimedia.org/r/609147

Change 610372 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (806716154)

https://gerrit.wikimedia.org/r/610372

Change 610372 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (806716154)

https://gerrit.wikimedia.org/r/610372

JTannerWMF edited projects, added Skipped QA; removed Editing QA.