Page MenuHomePhabricator
Create Task
Maniphest T256969

Visual diff containing signature node throws error, doesn't render the signature
Closed, ResolvedPublic
Actions

Description

  1. Open VE in a namespace that supports signatures
  2. Type ~~~~ to get a signature node
  3. Open the visual diff

4a. Observe there is an error in the console
4b. Observe no signature is rendered.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+3 -1Update VE core submodule to master (806716154)
mediawiki/extensions/VisualEditormaster+13 -3MWSignatureNode: Use template's rendering hash object
VisualEditor/VisualEditormaster+4 -4GeneratedContentNode: Don't try to render if model is detached
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jul 2 2020, 12:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2020, 12:18 PM
gerritbot added a comment.Jul 2 2020, 12:22 PM

Change 609143 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] GeneratedContentNode: Don't try to render if model is detached

https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/ /609143

gerritbot added a project: Patch-For-Review.Jul 2 2020, 12:22 PM
Esanders renamed this task from Visual diff containing signature node throws error to Visual diff containing signature node throws error, doesn't render the signature.Jul 2 2020, 1:17 PM
Esanders updated the task description. (Show Details)
gerritbot added a comment.Jul 2 2020, 1:18 PM

Change 609147 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] MWSignatureNode: Use template's rendering hash object

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/ /609147

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jul 3 2020, 2:26 AM
gerritbot added a comment.Jul 8 2020, 8:26 PM

Change 609143 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] GeneratedContentNode: Don't try to render if model is detached

https://gerrit.wikimedia.org/r/609143

gerritbot added a comment.Jul 8 2020, 8:47 PM

Change 609147 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWSignatureNode: Use template's rendering hash object

https://gerrit.wikimedia.org/r/609147

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 8 2020, 9:00 PM
gerritbot added a comment.Jul 8 2020, 9:02 PM

Change 610372 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (806716154)

https://gerrit.wikimedia.org/r/610372

gerritbot added a comment.Jul 8 2020, 9:23 PM

Change 610372 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (806716154)

https://gerrit.wikimedia.org/r/610372

matmarex added a project: Editing-team (FY2021-22 Kanban Board).Jul 8 2020, 9:30 PM
matmarex edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed Editing-team (FY2021-22 Kanban Board).
matmarex moved this task from Needs Discussion / Investigation to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.Jul 8 2020, 9:33 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.
MBinder_WMF edited projects, added Editing-team (FY2021-22 Kanban Board); removed Editing-team (Q3 2019-2020 Kanban Board).Jul 9 2020, 4:47 PM
JTannerWMF moved this task from Incoming to QA on the Editing-team (FY2021-22 Kanban Board) board.Jul 9 2020, 4:48 PM
• ppelberg moved this task from Inbox to Low Priority on the Editing QA board.Oct 1 2020, 11:17 PM
JTannerWMF closed this task as Resolved.Nov 25 2020, 6:32 PM
JTannerWMF moved this task from QA to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.
JTannerWMF edited projects, added Skipped QA; removed Editing QA.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 25 2020, 6:33 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL