Page MenuHomePhabricator

Deploy read-only mode for ShortUrl
Open, MediumPublic

Description

Context:

The main thing is that we no longer expose (old) ShortUrls anywhere, and we don't create any *new* ones.

we could keep ShortUrl as is, put it in a readonly mode.

So it looks like the outcome willl be that the current UI deployed on some wikis where short URLs are eagerly generated on page view (violates DBPerf, T122708) and shows them atop the page for sharing, is something that will no longer be supported.

Instead, people would need to use https://w.wiki, possibly via a gadget that produces a link like https://w.wiki/?url=URL so that users can still get there easily and then only have to submit the form to find or make the short url accordingly.

Perhaps we can already remove the current UI and eager generation today, ahead of T187045 and this task (T107188). If not, what is blocking that?

For this task:

  • Develop a read-only flag to the legacy ShortUrl extension.
  • Set the read-only flag. This will automatically resolve T122708.

Current wikis per CommonSettings.php source

// NO FURTHER DEPLOYMENTS OF THIS EXTENSION.
'wmgUseShortUrl' => [
	'default' => false,
	'bdwikimedia' => true, // T146014
	'bhwiki' => true, // T113348
	'bnwiki' => true, // T62956
	'bnwikisource' => true, // T127968
	'eswikibooks' => true, // T96668
	'gomwiki' => true, // T206741
	'hiwiki' => true,
	'hiwikiversity' => true, // T177187
	'knwiki' => true, // T97218
	'knwikisource' => true, // T189287
	'maiwiki' => true, // T125802
	'mrwiki' => true, // T103646
	'newiki' => true, // T92820
	'orwiki' => true,
	'orwikisource' => true, // T124429
	'orwiktionary' => true, // T103644
	'pawiki' => true, // T178919
	'sawiki' => true, // T94660
	'sawikibooks' => true, // T94660
	'sawikiquote' => true, // T94660
	'sawikisource' => true, // T94660
	'sawiktionary' => true, // T94660
	'tawiki' => true,
	'tawikibooks' => true,
	'tawikinews' => true,
	'tawikiquote' => true,
	'tawikisource' => true,
	'tawiktionary' => true,
	'tcywiki' => true, // T150166
	'test2wiki' => true,
	'urwiki' => true, // T138507
],

Event Timeline

Krinkle triaged this task as Medium priority.Jul 2 2020, 5:16 PM
Krinkle updated the task description. (Show Details)
  • Develop a read-only flag to the legacy ShortUrl extension.

Thanks to @Legoktm for excercising the bounds of our space-time continuum:

Change by Legoktm, merged on 7 July 2016:

[mediawiki/extensions/ShortUrl] Add read-only mode functionality

https://gerrit.wikimedia.org/r/297689

Krinkle edited projects, added Performance-Team; removed Performance-Team (Radar).
Krinkle moved this task from Doing (old) to Radar on the Performance-Team board.
Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.

Create a snippet on mediawiki.org as example gadget that provides a sidebar-integrated replacement for ShortUrl.

@Krinkle Stupid question: Now we do have a side-bar row for short url done by the new extension (url shortener) and it's deployed everywhere. Do you think it's good enough?

grafik.png (344×250 px, 21 KB)

Tagging our team to discuss the product question. We don't own the new UrlShortener extension in general, but we're taking it on briefly to do some essential work and resolving this question is blocker for sunsetting the old ShortUrl extension.

Krinkle added a subscriber: JTweed-WMF.

I showed the old and new UIs to @JTweed-WMF, using Hindi Wikipedia as example (https://hi.wikipedia.org), including the custom share menu they have which builds on the old "title caption" link outputted by the legacy ShortUrl extension.

He recommends that we reach out to the communities to give them a chance to update this to omit the legacy link and/or add a button that clicks the new "Get shortened URL" instead. We should also announce the change in Tech News, and after that we can proceed with adding a simplified reader compat mode to the new repo, and archive the old repo.

I've posted a revised plan at T107188#11181721.