| MBinder_WMF | |
| Jul 2 2020, 6:36 PM |
| F32243688: Screenshot_20200903_115044.png | |
| Sep 3 2020, 4:52 PM |
| F32140277: Screenshot 2020-08-14 at 19.16.47.png | |
| Aug 14 2020, 6:17 PM |
| F32078152: Screen Shot 2020-08-12 at 8.42.57 AM.png | |
| Aug 12 2020, 3:44 PM |
| F31914469: parsoid 3.jpg | |
| Jul 2 2020, 6:36 PM |
| F31914470: parsoid 2.jpg | |
| Jul 2 2020, 6:36 PM |
| F31914468: parsoid 1.jpg | |
| Jul 2 2020, 6:36 PM |
Steps to Reproduce:
I noticed these on the Parsoid board, and in the tasks themselves
Actual Results:
Expected Results:
These symbols are new to me, and I would expect them to have some context (e.g. a hover message) or be interactive, so I suspect a bug.
The symbol is for the Production Error subtype. It used to be PRODUCTION ERROR instead of ⚠.
It would be better (a11y) to have text displayed with the symbol. Failing that, I would expect hover text on the symbol.
https://phabricator.wikimedia.org/config/edit/maniphest.subtypes/ says:
"name": "Production Error", "tag": "\u26a0",
I'm not aware of any related task (or discussion elsewhere).
I agree it should be interactive and perhaps it's not the best choice of icon, however, I believe it is helpful to differentiate production errors with a visual icon because they are urgent.
I'd make it the name.
https://phabricator.wikimedia.org/config/edit/maniphest.subtypes/ says:
"name": "Production Error", "tag": "\u26a0",
Alternatively, make it show the symbol and text: ⚠ PRODUCTION ERROR.
Yea, that would be fine. If I'm iterating on that, I might make it really explicit, like
Error on Wikimedia Production
or something, just in case someone things it's Phab that has the error, but I'm nitpicking.
For the records, for most humans an error in production will be any wrong behavior ("bug" or "error") on production servers, like some button which doesn't work when I click it. I'm bikeshedding, but if we could have longer text anyway, something like Server-side logged errors and fatal exceptions could be clearer.
Can we get rid of this icon instead? I don't think it can add value.
There is already Wikimedia-production-error which seems sufficient and is also shown in the same contexts already, and has a clickable link and description that people can learn about.
Also, when the prod error template is used accidentally by someone and it gets untagged from the project the subtype and this icon generally remain - which is what was the case for the one that Max showed on the Parsoid workboard and let to this confusion.
^ That's not the cleanest but it's far clearer to me what it means. At the very least, I'm not concerned that Phab, itself, is broken. :)
Is it required that something is displayed in the project to represent the task subtype?
@Krinkle: Apparently there isn't a way to turn it off with config, I'll have to patch the code. I think it could be useful with some subtypes but it sucks that it shows on every subtype. I think I agree that it's not useful for this particular case.
