Page MenuHomePhabricator

Make memcached BagOStuff classes use 'gets' only if a CAS token is needed
Closed, ResolvedPublic

Description

This saves a few bytes on the response and, more importantly, makes mcrouter warmup-style config like https://gerrit.wikimedia.org/r/c/operations/puppet/+/594760 more practical when using BagOStuff. Most get() operations, and all getMulti() ones, do not need CAS tokens since they are not being used within BagOStuff::merge().

Event Timeline

aaron created this task.Jul 2 2020, 9:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2020, 9:29 PM

Change 609269 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] objectcache: only use memcached "gets" when tokens are needed

https://gerrit.wikimedia.org/r/609269

aaron moved this task from Inbox to Doing on the Performance-Team board.Jul 6 2020, 8:05 PM

Change 609269 merged by jenkins-bot:
[mediawiki/core@master] objectcache: only use memcached "gets" when tokens are needed

https://gerrit.wikimedia.org/r/609269

Krinkle closed this task as Resolved.Mon, Jul 20, 8:08 PM