Page MenuHomePhabricator

"Restore all default settings (in all sections)" doesn't actually restore settings in all the sections
Open, Needs TriagePublic

Description

The "Restore all default settings (in all sections)" button in the Preferences (restoreprefs message) doesn't exactly restore all the sections (tabs). The "in all sections" part was added in T35327, but at least on Wikimedia projects this is not precise: It doesn't restore the default preferences in the Beta features and Gadget tabs.

Both of these tabs are added by extensions, so it will be tricky to make this core message aware of it, but this is nevertheless the situation, and the current message is misleading.

I'm not sure what is the good solution. I can think of the following:

  • Rephrase the message to reflect this. Perhaps it can say something like: "Restore all default settings (in all sections except $1)", and $1 will be filled by the names of tabs that aren't auto-restored.
  • Actually make it restore all the tabs.
  • Change the UI to restore the preferences only in the current tab.

Event Timeline

Amire80 created this task.Jul 3 2020, 4:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2020, 4:38 PM