Clicking on entries in Gerrit's "show blame" view results in 404
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dancy
	Jul 3 2020, 8:29 PM

Description

To reproduce:

Visit https://gerrit.wikimedia.org/r/c/labs/tools/wikibugs2/+/450446/2/tests/data/stream_events/change_wip_false.json
Click on the "SHOW BLAME" text.
Click on one of the dated lines on the left hand side. They should all take you to commit 96a9d2ed07b89fb46a873961fd31e7ce901b475f but instead you get a 404 page at URL https://gerrit.wikimedia.org/q/96a9d2ed07b89fb46a873961fd31e7ce901b475f

Looks like the generated URL really needs to be
https://gerrit.wikimedia.org/r/q/96a9d2ed07b89fb46a873961fd31e7ce901b475f

(i.e., prefixed with /r/)

Details

	Subject	Repo	Branch	Lines +/-
	Bump gerrit.war to Gerrit 3.2.2-102-g3bbb138e13	operations/software/gerrit	deploy/wmf/stable-3.2	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		QChris	T186406 Polygerrit Outgoing reviews, Incoming reviews and Recently closed headings should be more different from commits
Resolved		None	T220801 PolyGerrit 2.15 UI does not support custom dashboards (supported from in 2.16+)
Resolved		QChris	T206453 Big empty space under patch description
			Restricted Task
Resolved		None	T210515 context links in diff don't use pointer cursor
Resolved		Paladox	T223278 "Server error: line 1:33 no viable alternative at character '['" when visiting particular patch
			Restricted Task
Resolved		hashar	T103990 Gerrit upload-pack send ALL references causing massive network I/O on common operations
Resolved		None	T195280 New Gerrit UI does not contain copyable Change-Id or parent commit id
Declined	Feature	None	T201246 Make a PolyGerrit plugin to welcome new users
Resolved		QChris	T254158 Gerrit 3.2 upgrade
Resolved	BUG REPORT	QChris	T257077 Clicking on entries in Gerrit's "show blame" view results in 404

Event Timeline

dancy created this task.Jul 3 2020, 8:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2020, 8:29 PM

QChris added a parent task: T254158: Gerrit 3.2 upgrade.Jul 3 2020, 8:36 PM

QChris changed the subtype of this task from "Task" to "Bug Report".

dancy updated the task description. (Show Details)Jul 3 2020, 8:43 PM

As a workaround (for users reading this) you can click on "Gitiles" (top left of diff) instead of "Show blame". Then click [blame]. The commit references there do open fine, and the Change-Ids are also clickable which take into the Gerrit context.

Fixed with https://gerrit-review.googlesource.com/c/gerrit/+/274356

Change 609590 had a related patch set uploaded (by QChris; owner: Christian Aistleitner):
[operations/software/gerrit@deploy/wmf/stable-3.2] Bump gerrit.war to Gerrit 3.2.2-102-g3bbb138e13

https://gerrit.wikimedia.org/r/609590

gerritbot added a project: Patch-For-Review.Jul 5 2020, 9:24 PM

Change 609590 merged by QChris:
[operations/software/gerrit@deploy/wmf/stable-3.2] Bump gerrit.war to Gerrit 3.2.2-102-g3bbb138e13

https://gerrit.wikimedia.org/r/609590

QChris mentioned this in rGERRITDEPLOYc8c1c9a8473a: Bump gerrit.war to Gerrit 3.2.2-102-g3bbb138e13.Jul 5 2020, 9:38 PM

Fix (Thanks @Paladox) is deployed and effective.

QChris closed this task as Resolved.Jul 5 2020, 9:58 PM

QChris claimed this task.

Maintenance_bot removed a project: Patch-For-Review.Jul 5 2020, 10:10 PM