Page MenuHomePhabricator

Reporting of edit failures due to AbuseFilter and SpamBlacklist
Closed, ResolvedPublic

Description

Check if something needs to be done in WPCleaner to handle the new way of reporting errors by the extensions AbuseFilter and SpamBlackList

Mail from Brad Jorsch on mediawik-api-announce on September 2019:

When saving an edit is prevented by the AbuseFilter or SpamBlacklist extensions, the error is currently reported as a successful API response with a 'failure' code in the body.[1][2]

In the future, these will be reported as standard API errors.[3][4]

This change should be deployed to Wikimedia wikis with 1.34.0-wmf.23. See https://www.mediawiki.org/wiki/MediaWiki_1.34/Roadmap for a schedule.

Clients that do not need to specially handle failures due to AbuseFilter or SpamBlacklist will likely need no changes, as they probably already include code to generically handle API error responses.

Clients that do handle AbuseFilter or SpamBlacklist failures specially will need to be updated to check for error codes 'abusefilter-warning', 'abusefilter-disallowed', and/or 'spamblacklist' and handle them as they do the current AbuseFilter and SpamBlacklist failures, if they want to preserve their current special handling.

Note that edit failures due to CAPTCHAs from ConfirmEdit are not being changed at this time. They will continue to be reported as before.[5]

[1]: AbuseFilter: https://phabricator.wikimedia.org/P8988
[2]: SpamBlacklist: https://phabricator.wikimedia.org/P8990
[3]: AbuseFilter: https://phabricator.wikimedia.org/P8989
[4]: SpamBlacklist: https://phabricator.wikimedia.org/P8991
[5]: ConfirmEdit: https://phabricator.wikimedia.org/P9076

Event Timeline

NicoV claimed this task.
NicoV moved this task from Backlog to Done on the WPCleaner board.

It seems nothing needs to be done, WPCleaner already correctly retrieves the error code and error message and displays them to the user.