Page MenuHomePhabricator

"Automatic changes to templates" edit misses fileimporter tag
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Example file history: https://commons.wikimedia.org/wiki/File:DoI.svg?action=history. Note how all edits do have the fileimporter tag, just not the automatic edit where the templates have been updated.

Reported here: https://www.mediawiki.org/wiki/Topic:Vpipm71eeybicmyp

Event Timeline

Change 609552 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Mark template cleanup edit with "fileimporter" tag as well

https://gerrit.wikimedia.org/r/609552

This comment was removed by awight.

Change 609552 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Mark template cleanup edit with "fileimporter" tag as well

https://gerrit.wikimedia.org/r/609552

awight set the point value for this task to 1.
awight moved this task from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2020-06-24 board.
awight changed the subtype of this task from "Task" to "Bug Report".
awight removed a subscriber: awight.
awight added a subscriber: awight.
Lena_WMDE closed this task as Resolved.Jul 7 2020, 11:37 AM
Lena_WMDE claimed this task.
Lena_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-06-24 board.

@Lena_WMDE Can the tag be added to the edit which adds Template:NowCommons to the original file as well?

MGA73 added a subscriber: MGA73.Fri, Jul 17, 1:47 PM

It is possible to [https://commons.wikimedia.org/w/index.php?title=File%3AEhime_pref_Hojo_highschool.jpg&type=revision&diff=433591068&oldid=433591067 change stuff] while importing and it still gets tagged as edited by FileImporter ;-)

Perhaps to be sure it should not be possible to change anything during transfer so it is clear what FileImporter does and what users does?

@Jonteemil, I created T258378.

@MGA73, thanks for the hint. This information is indeed missing here in this ticket. It's true: the last edit made by FileImporter contains both automatic edits as well as manual edits by the user doing the import. That's fine. The edit is still made with FileImporter. It's a common convention to mark edits with the tool that was used for the edit.