Page MenuHomePhabricator
Create Task
Maniphest T257136

Improve code style in ExternalData
Closed, ResolvedPublic
Actions

Description

This bug is created for various refactorings and improvements in code style in ExternalData.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/ExternalDatamaster+21 -14Fix broken POST and exotic encodings
mediawiki/extensions/ExternalDatamaster+100 -94Merge the class EDEncodingConverter into EDConnectorParsable and EDConnectorHttp.
mediawiki/extensions/ExternalDatamaster+81 -106Merge class EDHttpWithHeaders into EDConnectorHttp
mediawiki/extensions/ExternalDatamaster+173 -88Move parsing code from EDConnectorBase to the new trait EDConnectorParsable
mediawiki/extensions/ExternalDatamaster+1 -1Rename the automatic external variable 'text' as '__text'
mediawiki/extensions/ExternalDatamaster+247 -69Enable several PHPCS checks
mediawiki/extensions/ExternalDatamaster+22 -11Handle MongoDB exception
mediawiki/extensions/ExternalDatamaster+6 -1Handle empty or otherwise obviously invalid CSS selectors gracefully
mediawiki/extensions/ExternalDatamaster+9 -5Handle string errors from EDHttpWithHeaders::get in EDConnectorWeb::fetcher
mediawiki/extensions/ExternalDatamaster+3 -3Make __invoke signatures uniform in EDParser classes
mediawiki/extensions/ExternalDatamaster+3 -0Handle missing 'format' parameter gracefully in Lua
mediawiki/extensions/ExternalDatamaster+3 -6Handle XPath error gracefully
mediawiki/extensions/ExternalDatamaster+2 K -1 KRemove various connectors from EDUtils to separate classes
mediawiki/extensions/ExternalDatamaster+11 -11Correct errors in EDConnectorPost
mediawiki/extensions/ExternalDatamaster+1 K -722Remove text parsing from EDUtils to separate classes
mediawiki/extensions/ExternalDatamaster+1 K -718Remove text parsing from EDUtils to separate classes
Show related patches Customize query in gerrit

Event Timeline

alex-mashin created this task.Jul 5 2020, 8:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 5 2020, 8:08 AM
Akuckartz awarded a token.Jul 5 2020, 8:18 PM
Akuckartz added a subscriber: Akuckartz.
Aklapper added a project: Technical-Debt.Jul 8 2020, 11:09 AM
gerritbot added a comment.Jul 23 2020, 10:31 AM

Change 615696 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Remove text parsing from EDUtils to separate classes

https://gerrit.wikimedia.org/r/615696

gerritbot added a project: Patch-For-Review.Jul 23 2020, 10:31 AM
gerritbot added a comment.Jul 26 2020, 1:19 PM

Change 616323 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Remove text parsing from EDUtils to separate classes

https://gerrit.wikimedia.org/r/616323

gerritbot added a comment.Jul 26 2020, 1:21 PM

Change 615696 abandoned by Alex Mashin:
[mediawiki/extensions/ExternalData@master] Remove text parsing from EDUtils to separate classes

Reason:
I had to create a new change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ExternalData/ /616323/ to get out of merge conflicts.

https://gerrit.wikimedia.org/r/615696

gerritbot added a comment.Jul 27 2020, 3:22 PM

Change 616323 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Remove text parsing from EDUtils to separate classes

https://gerrit.wikimedia.org/r/616323

gerritbot added a comment.Jul 30 2020, 6:54 PM

Change 617521 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Remove various connectors from EDUtils to separate classes

https://gerrit.wikimedia.org/r/617521

gerritbot added a comment.Aug 5 2020, 2:42 PM

Change 617521 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Remove various connectors from EDUtils to separate classes

https://gerrit.wikimedia.org/r/617521

alex-mashin removed a project: Patch-For-Review.Aug 12 2020, 2:44 AM
gerritbot added a comment.Oct 6 2020, 3:28 AM

Change 632361 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Correct errors in EDConnectorPost

https://gerrit.wikimedia.org/r/632361

gerritbot added a project: Patch-For-Review.Oct 6 2020, 3:28 AM
gerritbot added a comment.Oct 6 2020, 4:07 AM

Change 632361 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Correct errors in EDConnectorPost

https://gerrit.wikimedia.org/r/632361

gerritbot added a comment.Nov 25 2020, 4:00 AM

Change 643390 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Handle missing 'format' parameter gracefully in Lua

https://gerrit.wikimedia.org/r/643390

gerritbot added a comment.Nov 25 2020, 5:22 AM

Change 643397 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Handle XPath error gracefully

https://gerrit.wikimedia.org/r/643397

gerritbot added a comment.Nov 25 2020, 6:17 AM

Change 643400 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Make __invoke signatures uniform in EDParser classes

https://gerrit.wikimedia.org/r/643400

gerritbot added a comment.Nov 25 2020, 6:41 AM

Change 643401 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Handle string errors from EDHttpWithHeaders::get in EDConnectorWeb::fetcher

https://gerrit.wikimedia.org/r/643401

gerritbot added a comment.Nov 25 2020, 5:24 PM

Change 643397 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Handle XPath error gracefully

https://gerrit.wikimedia.org/r/643397

gerritbot added a comment.Nov 25 2020, 5:54 PM

Change 643390 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Handle missing 'format' parameter gracefully in Lua

https://gerrit.wikimedia.org/r/643390

gerritbot added a comment.Nov 25 2020, 6:53 PM

Change 643400 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Make __invoke signatures uniform in EDParser classes

https://gerrit.wikimedia.org/r/643400

gerritbot added a comment.Nov 25 2020, 7:07 PM

Change 643401 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Handle string errors from EDHttpWithHeaders::get in EDConnectorWeb::fetcher

https://gerrit.wikimedia.org/r/643401

gerritbot added a comment.Nov 26 2020, 3:18 AM

Change 643606 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Handle empty or otherwise obviously invalid CSS selectors gracefully

https://gerrit.wikimedia.org/r/643606

gerritbot added a comment.Nov 27 2020, 2:03 AM

Change 643606 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Handle empty or otherwise obviously invalid CSS selectors gracefully

https://gerrit.wikimedia.org/r/643606

gerritbot added a comment.Dec 7 2020, 3:23 AM

Change 646153 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Handle MongoDB exception

https://gerrit.wikimedia.org/r/646153

gerritbot added a comment.Dec 7 2020, 3:18 PM

Change 646153 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Handle MongoDB exception

https://gerrit.wikimedia.org/r/646153

gerritbot added a comment.Apr 9 2021, 10:08 PM

Change 678289 had a related patch set uploaded (by Alex Mashin; author: mashin):

[mediawiki/extensions/ExternalData@master] Enable several PHPCS checks

https://gerrit.wikimedia.org/r/678289

gerritbot added a comment.Apr 14 2021, 4:06 PM

Change 678289 merged by jenkins-bot:

[mediawiki/extensions/ExternalData@master] Enable several PHPCS checks

https://gerrit.wikimedia.org/r/678289

alex-mashin removed a project: Patch-For-Review.Aug 22 2021, 1:54 PM
gerritbot added a comment.Aug 31 2021, 1:55 AM

Change 715641 had a related patch set uploaded (by Alex Mashin; author: mashin):

[mediawiki/extensions/ExternalData@master] Rename the automatic external variable 'text' as '__text'

https://gerrit.wikimedia.org/r/715641

gerritbot added a project: Patch-For-Review.Aug 31 2021, 1:55 AM
gerritbot added a comment.Aug 31 2021, 2:26 AM

Change 715641 merged by jenkins-bot:

[mediawiki/extensions/ExternalData@master] Rename the automatic external variable 'text' as '__text'

https://gerrit.wikimedia.org/r/715641

gerritbot added a comment.Sep 1 2021, 5:12 PM

Change 715999 had a related patch set uploaded (by Alex Mashin; author: mashin):

[mediawiki/extensions/ExternalData@master] Move parsing code from EDConnectorBase to the new trait EDConnectorParsable

https://gerrit.wikimedia.org/r/715999

gerritbot added a comment.Sep 1 2021, 7:17 PM

Change 715999 merged by jenkins-bot:

[mediawiki/extensions/ExternalData@master] Move parsing code from EDConnectorBase to the new trait EDConnectorParsable

https://gerrit.wikimedia.org/r/715999

alex-mashin removed a project: Patch-For-Review.Sep 4 2021, 8:16 AM
gerritbot added a comment.Oct 8 2021, 1:45 PM

Change 728460 had a related patch set uploaded (by Alex Mashin; author: mashin):

[mediawiki/extensions/ExternalData@master] Merge class EDHttpWithHeaders into EDConnectorHttp

https://gerrit.wikimedia.org/r/728460

gerritbot added a project: Patch-For-Review.Oct 8 2021, 1:45 PM
gerritbot added a comment.Oct 8 2021, 2:49 PM

Change 728492 had a related patch set uploaded (by Alex Mashin; author: mashin):

[mediawiki/extensions/ExternalData@master] Merge the class EDEncodingConverter into EDConnectorParsable and EDConnectorHttp.

https://gerrit.wikimedia.org/r/728492

gerritbot added a comment.Oct 8 2021, 2:50 PM

Change 728492 abandoned by Alex Mashin:

[mediawiki/extensions/ExternalData@master] Merge the class EDEncodingConverter into EDConnectorParsable and EDConnectorHttp.

Reason:

https://gerrit.wikimedia.org/r/728492

gerritbot added a comment.Oct 8 2021, 5:27 PM

Change 728460 merged by jenkins-bot:

[mediawiki/extensions/ExternalData@master] Merge class EDHttpWithHeaders into EDConnectorHttp

https://gerrit.wikimedia.org/r/728460

gerritbot added a comment.Oct 8 2021, 5:49 PM

Change 728492 restored by Alex Mashin:

[mediawiki/extensions/ExternalData@master] Merge the class EDEncodingConverter into EDConnectorParsable and EDConnectorHttp.

https://gerrit.wikimedia.org/r/728492

gerritbot added a comment.Oct 8 2021, 7:41 PM

Change 728492 merged by jenkins-bot:

[mediawiki/extensions/ExternalData@master] Merge the class EDEncodingConverter into EDConnectorParsable and EDConnectorHttp.

https://gerrit.wikimedia.org/r/728492

gerritbot added a comment.Oct 13 2021, 3:02 PM

Change 730542 had a related patch set uploaded (by Alex Mashin; author: mashin):

[mediawiki/extensions/ExternalData@master] Fix broken POST and exotic encodings

https://gerrit.wikimedia.org/r/730542

gerritbot added a comment.Oct 14 2021, 4:15 PM

Change 730542 merged by jenkins-bot:

[mediawiki/extensions/ExternalData@master] Fix broken POST and exotic encodings

https://gerrit.wikimedia.org/r/730542

alex-mashin closed this task as Resolved.Oct 31 2021, 1:56 PM
alex-mashin removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL