Page MenuHomePhabricator

Improve code style in ExternalData
Open, Needs TriagePublic

Description

This bug is created for various refactorings and improvements in code style in ExternalData.

Event Timeline

Change 615696 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Remove text parsing from EDUtils to separate classes

https://gerrit.wikimedia.org/r/615696

Change 616323 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Remove text parsing from EDUtils to separate classes

https://gerrit.wikimedia.org/r/616323

Change 615696 abandoned by Alex Mashin:
[mediawiki/extensions/ExternalData@master] Remove text parsing from EDUtils to separate classes

Reason:
I had to create a new change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ExternalData/ /616323/ to get out of merge conflicts.

https://gerrit.wikimedia.org/r/615696

Change 616323 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Remove text parsing from EDUtils to separate classes

https://gerrit.wikimedia.org/r/616323

Change 617521 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Remove various connectors from EDUtils to separate classes

https://gerrit.wikimedia.org/r/617521

Change 617521 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Remove various connectors from EDUtils to separate classes

https://gerrit.wikimedia.org/r/617521

Change 632361 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Correct errors in EDConnectorPost

https://gerrit.wikimedia.org/r/632361

Change 632361 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Correct errors in EDConnectorPost

https://gerrit.wikimedia.org/r/632361

Change 643390 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Handle missing 'format' parameter gracefully in Lua

https://gerrit.wikimedia.org/r/643390

Change 643397 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Handle XPath error gracefully

https://gerrit.wikimedia.org/r/643397

Change 643400 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Make __invoke signatures uniform in EDParser classes

https://gerrit.wikimedia.org/r/643400

Change 643401 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Handle string errors from EDHttpWithHeaders::get in EDConnectorWeb::fetcher

https://gerrit.wikimedia.org/r/643401

Change 643397 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Handle XPath error gracefully

https://gerrit.wikimedia.org/r/643397

Change 643390 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Handle missing 'format' parameter gracefully in Lua

https://gerrit.wikimedia.org/r/643390

Change 643400 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Make __invoke signatures uniform in EDParser classes

https://gerrit.wikimedia.org/r/643400

Change 643401 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Handle string errors from EDHttpWithHeaders::get in EDConnectorWeb::fetcher

https://gerrit.wikimedia.org/r/643401

Change 643606 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Handle empty or otherwise obviously invalid CSS selectors gracefully

https://gerrit.wikimedia.org/r/643606

Change 643606 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Handle empty or otherwise obviously invalid CSS selectors gracefully

https://gerrit.wikimedia.org/r/643606

Change 646153 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Handle MongoDB exception

https://gerrit.wikimedia.org/r/646153

Change 646153 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Handle MongoDB exception

https://gerrit.wikimedia.org/r/646153

Change 678289 had a related patch set uploaded (by Alex Mashin; author: mashin):

[mediawiki/extensions/ExternalData@master] Enable several PHPCS checks

https://gerrit.wikimedia.org/r/678289

Change 678289 merged by jenkins-bot:

[mediawiki/extensions/ExternalData@master] Enable several PHPCS checks

https://gerrit.wikimedia.org/r/678289

Change 715641 had a related patch set uploaded (by Alex Mashin; author: mashin):

[mediawiki/extensions/ExternalData@master] Rename the automatic external variable 'text' as '__text'

https://gerrit.wikimedia.org/r/715641

Change 715641 merged by jenkins-bot:

[mediawiki/extensions/ExternalData@master] Rename the automatic external variable 'text' as '__text'

https://gerrit.wikimedia.org/r/715641

Change 715999 had a related patch set uploaded (by Alex Mashin; author: mashin):

[mediawiki/extensions/ExternalData@master] Move parsing code from EDConnectorBase to the new trait EDConnectorParsable

https://gerrit.wikimedia.org/r/715999

Change 715999 merged by jenkins-bot:

[mediawiki/extensions/ExternalData@master] Move parsing code from EDConnectorBase to the new trait EDConnectorParsable

https://gerrit.wikimedia.org/r/715999