Page MenuHomePhabricator
Create Task
Maniphest T257151

Edit and close icons not horizontally aligned in mobile
Closed, ResolvedPublic
Actions

Description

Screenshot_20200705-190454.png (944×1 px, 78 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (99d104900)mediawiki/extensions/VisualEditormaster+1 -1
ve.ui.LinearContextItem: Fix alignment of the close button on mobileVisualEditor/VisualEditormaster+4 -8
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jul 5 2020, 6:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 5 2020, 6:13 PM
JTannerWMF added projects: UX-Debt, Editing-team (Tracking).Jul 14 2020, 3:41 PM
JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.
JTannerWMF moved this task from Backlog to FY2020-21 on the Editing-team (Tracking) board.
matmarex subscribed.Jul 14 2020, 6:20 PM

I think I broke it with 6ffa100f23ae3ca60177c360b1912a7650e10606 (https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/598548).

gerritbot added a comment.Jul 14 2020, 6:35 PM

Change 612642 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.LinearContextItem: Fix alignment of the close button on mobile

https://gerrit.wikimedia.org/r/612642

gerritbot added a project: Patch-For-Review.Jul 14 2020, 6:35 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team (Tracking).Jul 14 2020, 6:36 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
Esanders assigned this task to matmarex.Jul 14 2020, 10:20 PM
gerritbot added a comment.Jul 14 2020, 10:25 PM

Change 612642 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.LinearContextItem: Fix alignment of the close button on mobile

https://gerrit.wikimedia.org/r/612642

Esanders moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Jul 14 2020, 10:26 PM
Esanders added a project: Skipped QA.
Maintenance_bot removed a project: Patch-For-Review.Jul 14 2020, 11:10 PM
gerritbot added a comment.Jul 15 2020, 11:47 PM

Change 612986 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (99d104900)

https://gerrit.wikimedia.org/r/612986

gerritbot added a project: Patch-For-Review.Jul 15 2020, 11:47 PM
gerritbot added a comment.Jul 16 2020, 8:57 AM

Change 612986 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (99d104900)

https://gerrit.wikimedia.org/r/612986

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 16 2020, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 16 2020, 9:10 AM
ppelberg closed this task as Resolved.Jul 17 2020, 2:04 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 17 2020, 2:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits