Maniphest T257164

Drop ConfirmEdit's AllowConfirmedEmail variable
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	Jul 5 2020, 10:35 PM

Project Tags

Referenced Files

None

Subscribers

Description

$wgAllowConfirmedEmail is equivalent to $wgGroupPermissions['emailconfirmed']['skipcaptcha'] = true; (see code) so there is no point in it existing; it just makes configuration more complicated. (Presumably the emailconfirmed class did not exist when it was added.) It should be deprecated and eventually removed.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Remove deprecated $wgAllowConfirmedEmail	Reedy	mediawiki/extensions/ConfirmEdit	master	+4 -42
	Remove deprecated $wgAllowConfirmedEmail	Zabe	mediawiki/extensions/ConfirmEdit	master	+7 -30
	Deprecate $wgAllowConfirmedEmail	Zabe	mediawiki/extensions/ConfirmEdit	master	+3 -0

Customize query in gerrit

Event Timeline

Tgr created this task.Jul 5 2020, 10:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 5 2020, 10:35 PM

Tgr added a project: good first task.Jul 5 2020, 10:36 PM

Zabe claimed this task.Mar 10 2021, 3:21 PM

Zabe added a project: User-Zabe.

Zabe moved this task from Backlog to Deprecation on the User-Zabe board.

Zabe subscribed.

Change 670490 had a related patch set uploaded (by Zabe; owner: Zabe):
[mediawiki/extensions/ConfirmEdit@master] Deprecate $wgAllowConfirmedEmail

https://gerrit.wikimedia.org/r/670490

gerritbot added a project: Patch-For-Review.Mar 10 2021, 3:35 PM

Change 670490 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Deprecate $wgAllowConfirmedEmail

https://gerrit.wikimedia.org/r/670490

Maintenance_bot removed a project: Patch-For-Review.Mar 30 2021, 6:11 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.38; 2021-04-06).Mar 30 2021, 7:00 PM

Change 704196 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/ConfirmEdit@master] Deprecate $wgAllowConfirmedEmail

https://gerrit.wikimedia.org/r/704196

gerritbot added a project: Patch-For-Review.Jul 13 2021, 12:18 AM

Change 704196 abandoned by Zabe:

[mediawiki/extensions/ConfirmEdit@master] Remove deprecated $wgAllowConfirmedEmail

Reason:

https://gerrit.wikimedia.org/r/704196

not working on this.

Maintenance_bot removed a project: Patch-For-Review.Apr 10 2022, 10:30 PM

Zabe removed a project: User-Zabe.Apr 13 2022, 1:21 AM

HouseBlaster moved this task from Unsorted to Needs removal on the Technical-Debt board.Dec 3 2022, 1:16 AM

Reedy moved this task from Backlog to Feature Requests/Improvements on the ConfirmEdit (CAPTCHA extension) board.Oct 24 2024, 1:27 AM

lcawte subscribed.May 2 2025, 10:38 AM

Deprecated in 1.36... Time for us to probably remove this (1.44 is cut, so would go in 1.45)

Change #1148406 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmEdit@master] Remove deprecated $wgAllowConfirmedEmail

https://gerrit.wikimedia.org/r/1148406

gerritbot added a project: Patch-For-Review.May 20 2025, 5:48 PM

Change #1148406 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] Remove deprecated $wgAllowConfirmedEmail

https://gerrit.wikimedia.org/r/1148406

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2025, 2:31 PM

Reedy closed this task as Resolved.Jun 23 2025, 6:52 PM

Reedy claimed this task.

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.8; 2025-07-01).Jun 24 2025, 3:02 PM