Page MenuHomePhabricator
Create Task
Maniphest T257165

OOUI PopupWidget : need to Notify caller when popup widget closes
Closed, ResolvedPublicBUG REPORT
Actions

Description

Automatically closes the popup when user tabs away
from the PopupWidget.

Close event allows widget callers to get notified when widget closes
This allows caller do things like get focus back.

Also, adding aria-label to close button.

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.39.3mediawiki/coremaster+209 -93
PopupWidget: Notify caller when popup widget closesoojs/uimaster+40 -2
Customize query in gerrit

Related Objects

Event Timeline

Tam-edwin-microsoft created this task.Jul 5 2020, 10:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 5 2020, 10:52 PM
gerritbot added a comment.Jul 5 2020, 10:53 PM

Change 585342 had a related patch set uploaded (by Tam-edwin-microsoft; owner: Akinwale-microsoft):
[oojs/ui@master] PopupWidget: Notify caller when popup widget closes

https://gerrit.wikimedia.org/r/585342

gerritbot added a project: Patch-For-Review.Jul 5 2020, 10:53 PM
Volker_E mentioned this in T257385: Window: focus lost when navigating with shift + tab key.Jul 8 2020, 11:08 PM
gerritbot added a comment.Jul 9 2020, 12:56 PM

Change 585342 merged by jenkins-bot:
[oojs/ui@master] PopupWidget: Notify caller when popup widget closes

https://gerrit.wikimedia.org/r/585342

matmarex moved this task from Backlog to Next-up on the OOUI board.Jul 9 2020, 1:01 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 9 2020, 1:11 PM
Volker_E moved this task from Next-up to OOUI-0.39.3 on the OOUI board.Jul 9 2020, 6:42 PM
Volker_E edited projects, added OOUI (OOUI-0.39.3); removed OOUI.
Tam-edwin-microsoft added a comment.EditedJul 10 2020, 2:50 AM

Hi, I just want to confirm if this T257165 and T257167 will make MW 1.35 next week.
Because I see in Gerrit the v0.39.3 tag happened on July 08 while the actual merge of the patches happened later on July 09

Thanks!

gerritbot added a comment.Jul 10 2020, 7:09 AM

Change 611174 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.39.3

https://gerrit.wikimedia.org/r/611174

gerritbot added a project: Patch-For-Review.Jul 10 2020, 7:09 AM
gerritbot added a comment.Jul 10 2020, 10:32 AM

Change 611174 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.39.3

https://gerrit.wikimedia.org/r/611174

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2020, 11:10 AM
Volker_E subscribed.Jul 10 2020, 6:14 PM

@Tam-edwin-microsoft All of the patches where “Update OOUI to v0.39.3” have made it onto the next release still in time for 1.35, rollout starting next Tuesday. :)

Volker_E closed this task as Resolved.Jul 10 2020, 6:15 PM
Volker_E triaged this task as Medium priority.
Tam-edwin-microsoft added a comment.Jul 10 2020, 6:18 PM

Awesome, thanks a lot @Volker_E! I have tagged a couple patches on the mediawiki side that use the new popup events for review. T257171 T257173 and T257175

Tam-edwin-microsoft mentioned this in T259912: Keyboard Tabbing Order for PopupWidget in Reverse(shift-tabbing) is out-of-order.Aug 7 2020, 6:48 PM
Tam-edwin-microsoft mentioned this in T260156: PopupToolGroup cannot be accessed by Keyboard unless PopupWidget is opened.Aug 11 2020, 3:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL