Page MenuHomePhabricator

Visual Editor: Help Popup close button does not have name property
Closed, ResolvedPublic

Description

​User Impact:​
Screen reader user does not get name of the control and also get confused about the control if it does not announces the correct information.

Event Timeline

Change 585608 had a related patch set uploaded (by Tam-edwin-microsoft; owner: Akinwale-microsoft):
[mediawiki/core@master] Fix: Adding close label to Resources.php file

https://gerrit.wikimedia.org/r/585608

Change 585608 merged by jenkins-bot:
[mediawiki/core@master] Fix: Adding close label to Resources.php file

https://gerrit.wikimedia.org/r/585608

The label was actually added in https://gerrit.wikimedia.org/r/c/oojs/ui/+/585342 (99ca76b8b9f110bf791b9f431503dc9c9011e9db), the other patch only updated the module definition in MediaWiki.

Affect all uses of PopupWidet, not just the visual editor.

matmarex edited projects, added OOUI (OOUI-0.39.3); removed OOUI.