Visual Editor: Help Popup close button does not have name property
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tam-edwin-microsoft
	Jul 6 2020, 5:12 AM

Description

User Impact:
Screen reader user does not get name of the control and also get confused about the control if it does not announces the correct information.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix: Adding close label to Resources.php file	mediawiki/core	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned Here: rGOJU99ca76b8b9f1: PopupWidget: Notify caller when popup widget closes

Event Timeline

Tam-edwin-microsoft created this task.Jul 6 2020, 5:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2020, 5:12 AM

Change 585608 had a related patch set uploaded (by Tam-edwin-microsoft; owner: Akinwale-microsoft):
[mediawiki/core@master] Fix: Adding close label to Resources.php file

https://gerrit.wikimedia.org/r/585608

gerritbot added a project: Patch-For-Review.Jul 6 2020, 5:17 AM

Change 585608 merged by jenkins-bot:
[mediawiki/core@master] Fix: Adding close label to Resources.php file

https://gerrit.wikimedia.org/r/585608

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 10 2020, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2020, 11:10 AM

The label was actually added in https://gerrit.wikimedia.org/r/c/oojs/ui/+/585342 (99ca76b8b9f110bf791b9f431503dc9c9011e9db), the other patch only updated the module definition in MediaWiki.

Affect all uses of PopupWidet, not just the visual editor.

matmarex closed this task as Resolved.Jul 10 2020, 11:51 AM

matmarex edited projects, added OOUI (OOUI-0.39.3); removed OOUI.

Visual Editor: Help Popup close button does not have name propertyClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Visual Editor: Help Popup close button does not have name property
Closed, ResolvedPublic
Actions