$wgShellRestrictionMethod = 'autodetect' is broken, will always think firejail is installed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Jul 7 2020, 6:51 AM

Description

See my comment on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/546788 - ExecutableFinder returns false while it's now checking for null.

This regression was only introduced in the 1.35 dev cycle.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	shell: Fix autodetection of firejail in findFirejail()	mediawiki/core	master	+9 -5

Customize query in gerrit

Event Timeline

Legoktm created this task.Jul 7 2020, 6:51 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2020, 6:51 AM

Change 609911 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] shell: Fix autodetection of firejail in findFirejail()

https://gerrit.wikimedia.org/r/609911

gerritbot added a project: Patch-For-Review.Jul 7 2020, 6:58 AM

Jdforrester-WMF subscribed.Jul 7 2020, 9:42 AM

Change 609911 merged by jenkins-bot:
[mediawiki/core@master] shell: Fix autodetection of firejail in findFirejail()

https://gerrit.wikimedia.org/r/609911

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 7 2020, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 7 2020, 2:10 PM

Legoktm closed this task as Resolved.Jul 8 2020, 6:38 AM

$wgShellRestrictionMethod = 'autodetect' is broken, will always think firejail is installedClosed, ResolvedPublicActions

Description

Details

Event Timeline

$wgShellRestrictionMethod = 'autodetect' is broken, will always think firejail is installed
Closed, ResolvedPublic
Actions