Page MenuHomePhabricator

$wgShellRestrictionMethod = 'autodetect' is broken, will always think firejail is installed
Closed, ResolvedPublic

Description

See my comment on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/546788 - ExecutableFinder returns false while it's now checking for null.

This regression was only introduced in the 1.35 dev cycle.

Event Timeline

Legoktm created this task.Jul 7 2020, 6:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2020, 6:51 AM

Change 609911 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] shell: Fix autodetection of firejail in findFirejail()

https://gerrit.wikimedia.org/r/609911

Change 609911 merged by jenkins-bot:
[mediawiki/core@master] shell: Fix autodetection of firejail in findFirejail()

https://gerrit.wikimedia.org/r/609911

Legoktm closed this task as Resolved.Jul 8 2020, 6:38 AM