Page MenuHomePhabricator

Beta cluster wikidata fails to load scripts with "OutOfBoundsException from line 60 of /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/SettingsArray.php: Attempt to get non-existing setting "repoScriptPath"
Closed, ResolvedPublicPRODUCTION ERROR

Description

I recieve the following error on my browser's console when opening https://wikidata.beta.wmflabs.org/wiki/Q371142 and most interactive components on beta cluster's Wikidata are broken.

Details

Request URL
https://test.wikidata.org/w/load.php?debug=true&lang=en-gb&modules=mw.config.values.wbRepo&only=scripts&skin=vector&version=3vboq
Stack Trace

OutOfBoundsException from line 60 of /srv/mediawiki/php-1.35.0-wmf.40/extensions/Wikibase/lib/includes/SettingsArray.php: Attempt to get non-existing setting "repoScriptPath"
Backtrace:
#0 /srv/mediawiki/php-1.35.0-wmf.40/extensions/Wikibase/lib/includes/Modules/RepoAccessModule.php(39): Wikibase\Lib\SettingsArray->getSetting(string)
#1 /srv/mediawiki/php-1.35.0-wmf.40/includes/resourceloader/ResourceLoaderModule.php(717): Wikibase\Lib\Modules\RepoAccessModule->getScript(ResourceLoaderContext)
#2 /srv/mediawiki/php-1.35.0-wmf.40/includes/resourceloader/ResourceLoaderModule.php(685): ResourceLoaderModule->buildContent(ResourceLoaderContext)
#3 /srv/mediawiki/php-1.35.0-wmf.40/includes/resourceloader/ResourceLoader.php(1191): ResourceLoaderModule->getModuleContent(ResourceLoaderContext)
#4 /srv/mediawiki/php-1.35.0-wmf.40/includes/resourceloader/ResourceLoader.php(899): ResourceLoader->makeModuleResponse(ResourceLoaderContext, array, array)
#5 /srv/mediawiki/php-1.35.0-wmf.40/load.php(51): ResourceLoader->respond(ResourceLoaderContext)
#6 /srv/mediawiki/php-1.35.0-wmf.40/load.php(38): wfLoadMain()
#7 /srv/mediawiki/w/load.php(3): require(string)
#8 {main}

Event Timeline

@Majavah could not reproduce - is there something specific that should be done to trigger the error?

@Majavah could not reproduce - is there something specific that should be done to trigger the error?

Look at your browser's console - I can reproduce after clearing all caches

Jdforrester-WMF triaged this task as Unbreak Now! priority.Jul 7 2020, 12:23 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Train blocker.

Jdforrester-WMF changed the subtype of this task from "Task" to "Production Error".
Jdforrester-WMF set Phatality ID to 4e21692aeaa0980795409dd285cd84a3ce939da062d54137eb95af63217a3d94.
Jdforrester-WMF set Request URL to test.wikidata.org/w/load.php?lang=en&modules=dataValues%2Cjquery%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Csite%2CvalueFormatters%2CvalueParsers%2Cvue2%2Cwikibase%7CdataValues.DataValue%2CTimeValue%2Cvalues%7Cext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CkvStore%2CstartUp%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.citoid.wikibase.init%7Cext.echo.api%2Cinit%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.uls.common%2Ccompactlinks%2Ci18n%2Cinit%2Cinterface%2Clanguagenames%2Cmediawiki%2Cmessages%2Cpreferences%2Cwebfonts%7Cext.wikimediaEvents.loggedin%2Cwikibase%7Cjquery.animateWithEvent%2Cclient%2Ccookie%2Ci18n%2Cinputautoexpand%2CjStorage%2CmakeCollapsible%2Cspinner%2CtextSelection%2Cthrottle-debounce%2Ctipsy%2Cui%2Culs%2Cvalueview%7Cjquery.event.special.eachchange%7Cjquery.spinner.styles%7Cjquery.ui.commonssuggester%2Clanguagesuggester%2Csuggester%7Cjquery.uls.data%2Cgrid%7Cjquery.util.getDirectionality%7Cjquery.valueview.Expert%2CExpertExtender%2CExpertStore%7Cjquery.valueview.experts.CommonsMediaType%2CEmptyValue%2CGeoShape%2CGlobeCoordinateInput%2CMonolingualText%2CQuantityInput%2CStringValue%2CTabularData%2CTimeInput%2CUnDeserializableValue%7Cjquery.wikibase.entityselector%2Csiteselector%2Cwbtooltip%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Cuser%2Cutil%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.page.watch.ajax%7Cmediawiki.ui.button%7Cmw.config.values.wbDataTypes%2CwbRefTabsEnabled%2CwbRepo%2CwbSiteDetails%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.indicators%7CpropertySuggester.suggestions%7Cskins.vector.legacy.js%7Cuser.defaults%7Cutil.ContentLanguages%2CExtendable%2CMessageProvider%2CMessageProviders%2CNotifier%2ChighlightSubstring%2Cinherit%7CvalueParsers.ValueParserStore%2Cparsers%7Cwikibase.EntityInitializer%2CSite%2CWikibaseContentLanguages%2CbuildErrorOutput%2Cdatamodel%2CgetLanguageNameByCode%2CgetUserLanguages%2Cserialization%2Csites%2Ctainted-ref%2Ctemplates%7Cwikibase.api.RepoApi%2CValueCaller%7Cwikibase.entityChangers.EntityChangersFactory%7Cwikibase.entityPage.entityLoaded%7Cwikibase.experts.Entity%2CForm%2CItem%2CLexeme%2CProperty%2CSense%2C__namespace%2Cmodules%7Cwikibase.formatters.ApiValueFormatter%7Cwikibase.quality.constraints.gadget%2Cicon%2Csuggestions%2Cui%7Cwikibase.ui.entityViewInit%2Centitysearch%7Cwikibase.utilities.ClaimGuidGenerator%7Cwikibase.view.ControllerViewFactory%2CReadModeViewFactory%2C__namespace&skin=vector&version=15oiy.Jul 7 2020, 12:26 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF edited Stack Trace. (Show Details)
Jdforrester-WMF changed Request URL from test.wikidata.org/w/load.php?lang=en&modules=dataValues%2Cjquery%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Csite%2CvalueFormatters%2CvalueParsers%2Cvue2%2Cwikibase%7CdataValues.DataValue%2CTimeValue%2Cvalues%7Cext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CkvStore%2CstartUp%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.citoid.wikibase.init%7Cext.echo.api%2Cinit%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.uls.common%2Ccompactlinks%2Ci18n%2Cinit%2Cinterface%2Clanguagenames%2Cmediawiki%2Cmessages%2Cpreferences%2Cwebfonts%7Cext.wikimediaEvents.loggedin%2Cwikibase%7Cjquery.animateWithEvent%2Cclient%2Ccookie%2Ci18n%2Cinputautoexpand%2CjStorage%2CmakeCollapsible%2Cspinner%2CtextSelection%2Cthrottle-debounce%2Ctipsy%2Cui%2Culs%2Cvalueview%7Cjquery.event.special.eachchange%7Cjquery.spinner.styles%7Cjquery.ui.commonssuggester%2Clanguagesuggester%2Csuggester%7Cjquery.uls.data%2Cgrid%7Cjquery.util.getDirectionality%7Cjquery.valueview.Expert%2CExpertExtender%2CExpertStore%7Cjquery.valueview.experts.CommonsMediaType%2CEmptyValue%2CGeoShape%2CGlobeCoordinateInput%2CMonolingualText%2CQuantityInput%2CStringValue%2CTabularData%2CTimeInput%2CUnDeserializableValue%7Cjquery.wikibase.entityselector%2Csiteselector%2Cwbtooltip%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Cuser%2Cutil%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.page.watch.ajax%7Cmediawiki.ui.button%7Cmw.config.values.wbDataTypes%2CwbRefTabsEnabled%2CwbRepo%2CwbSiteDetails%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.indicators%7CpropertySuggester.suggestions%7Cskins.vector.legacy.js%7Cuser.defaults%7Cutil.ContentLanguages%2CExtendable%2CMessageProvider%2CMessageProviders%2CNotifier%2ChighlightSubstring%2Cinherit%7CvalueParsers.ValueParserStore%2Cparsers%7Cwikibase.EntityInitializer%2CSite%2CWikibaseContentLanguages%2CbuildErrorOutput%2Cdatamodel%2CgetLanguageNameByCode%2CgetUserLanguages%2Cserialization%2Csites%2Ctainted-ref%2Ctemplates%7Cwikibase.api.RepoApi%2CValueCaller%7Cwikibase.entityChangers.EntityChangersFactory%7Cwikibase.entityPage.entityLoaded%7Cwikibase.experts.Entity%2CForm%2CItem%2CLexeme%2CProperty%2CSense%2C__namespace%2Cmodules%7Cwikibase.formatters.ApiValueFormatter%7Cwikibase.quality.constraints.gadget%2Cicon%2Csuggestions%2Cui%7Cwikibase.ui.entityViewInit%2Centitysearch%7Cwikibase.utilities.ClaimGuidGenerator%7Cwikibase.view.ControllerViewFactory%2CReadModeViewFactory%2C__namespace&skin=vector&version=15oiy to https://test.wikidata.org/w/load.php?debug=true&lang=en-gb&modules=mw.config.values.wbRepo&only=scripts&skin=vector&version=3vboq.Jul 7 2020, 2:15 PM

For unblocking wmf.40, I believe the best option is to revert I193008a732, though I hope we’ll find a proper fix for the master branch (and wmf.41 – or will that be wmf.1 of the next release?).

Change 610005 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Revert "Don’t load $wgWBClientSettings in WikibaseClient.php"

https://gerrit.wikimedia.org/r/610005

Change 610086 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.40] Revert "Don’t load $wgWBClientSettings in WikibaseClient.php"

https://gerrit.wikimedia.org/r/610086

Change 610005 abandoned by Lucas Werkmeister (WMDE):
[mediawiki/extensions/Wikibase@master] Revert "Don’t load $wgWBClientSettings in WikibaseClient.php"

Reason:
We’d like to revert this only on wmf.40, and find a better fix for the master branch. (But if we don’t manage to do that, this revert can be unabandoned and merged for wmf.41.)

https://gerrit.wikimedia.org/r/610005

For unblocking wmf.40, I believe the best option is to revert I193008a732, though I hope we’ll find a proper fix for the master branch (and wmf.41 – or will that be wmf.1 of the next release?).

Next week will be wmf.41, the last of 1.35.0 alphas, yes.

Change 610086 merged by Lucas Werkmeister (WMDE):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.40] Revert "Don’t load $wgWBClientSettings in WikibaseClient.php"

https://gerrit.wikimedia.org/r/610086

Mentioned in SAL (#wikimedia-operations) [2020-07-07T16:40:43Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.35.0-wmf.40/extensions/Wikibase: Backport: [[gerrit:610086|Revert "Don’t load $wgWBClientSettings in WikibaseClient.php" (T257296)]] (duration: 01m 10s)

Lucas_Werkmeister_WMDE lowered the priority of this task from Unbreak Now! to High.Jul 7 2020, 4:42 PM

Should be fixed now, though the broken module may linger in caches for a little bit (I’m not sure how long).

Moving as a blocker for next week since the issue has been fixed on wmf.40 but not on wmf.41

Moving as a blocker for next week since the issue has been fixed on wmf.40 but not on wmf.41

I already made T257334 a blocker for wmf.41.