Page MenuHomePhabricator

Remove \Wikibase\Lib\Settings
Closed, ResolvedPublic

Description

As part of the effort to move WikibaseClient to extension registration, we stopped loading $wgWBClientSettings in the PHP entry point (WikibaseClient.php) – instead, the default settings are loaded (and merged with the custom settings) at a later time, in the WikibaseSettings class.

However, we forgot about the Settings class (\Wikibase\Lib\Settings), which is a kind of duplicate settings system, separate from WikibaseSettings (deprecated a while ago, two remaining users). This class still directly accesses the $wgWBClientSettings global, so now it’s missing all the default settings.

The proper solution for that, we believe, is to move the remaining two users of this class to WikibaseSettings, and then to get rid of the class. (Note that for the parent task, to unblock the train, we’re going with the simpler solution of reverting the change that stopped loading $wgWBClientSettings in WikibaseClient.php.)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2020, 3:55 PM
Lucas_Werkmeister_WMDE triaged this task as High priority.Jul 7 2020, 3:56 PM

Marking this as a train blocker so we don’t forget – if we don’t properly resolve this task, then the revert for wmf.40 will also have to be applied to wmf.41 as well.

Change 610109 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Stop using Settings in RepoAccessModule

https://gerrit.wikimedia.org/r/610109

Change 610115 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Stop using Settings in SitesModule

https://gerrit.wikimedia.org/r/610115

Change 610117 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove \Wikibase\Lib\Settings

https://gerrit.wikimedia.org/r/610117

Change 610109 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop using Settings in RepoAccessModule

https://gerrit.wikimedia.org/r/610109

Change 610115 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop using Settings in SitesModule

https://gerrit.wikimedia.org/r/610115

Change 610117 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove \Wikibase\Lib\Settings

https://gerrit.wikimedia.org/r/610117

Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 8 2020, 8:05 AM

Seems to be working, no more errors on Beta.