Page MenuHomePhabricator

Fix the proxy behavior for Kubernetes on toolsbeta
Closed, ResolvedPublic

Description

The new domain and the funneling of traffic to it has made toolsbeta's Kubernetes no longer functional. It redirects to <tool>.toolforge.org, which won't really do the thing.

We should fix this because it was pretty nice to have a test environment previously.

Event Timeline

What should the root domain be for toolsbeta? A few possibilities:

  • beta.toolforge.org
  • toolsbeta.toolforge.org
  • toolsbeta.wmcloud.org

I put both "beta" and "toolsbeta" on the deny list for tool names back in November so that they would be ok to use in this manner.

It should probably be beta.toolforge.org as it's Toolforge and the 'tools' bit isn't really needed anymore as it was only there to match tools.wmflabs.org

I was looking into what it would take to fix this, but at least locally setting a Host header seems to work fine:

legoktm@toolsbeta-proxy-1:~$ curl -H "Host: test.toolforge.org" localhost 
Hello World, from Toolsbeta!

At least this addresses my usecase of being able to access tools locally. Is there any functionality that this is missing? If so I can take a stab at fixing it properly.

Oh! That's good to hear. It was set up so that it was possible to hit with a straight curl to the address from toolsbeta-sgebastion-04. That's almost certainly not going to work now, but this does unblock you, actually.

@bd808 I vote for beta.toolforge.org as well.

Change 916874 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/software/tools-webservice@master] kubernetes: Allow configuring the toolforge.org public domain

https://gerrit.wikimedia.org/r/916874

Change 916875 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] P:toolforge: webservice: set public_domain config

https://gerrit.wikimedia.org/r/916875

Change 916875 merged by Arturo Borrero Gonzalez:

[operations/puppet@production] P:toolforge: webservice: set public_domain config

https://gerrit.wikimedia.org/r/916875

Change 916874 merged by jenkins-bot:

[operations/software/tools-webservice@master] kubernetes: Allow configuring the toolforge.org public domain

https://gerrit.wikimedia.org/r/916874

Mentioned in SAL (#wikimedia-cloud) [2023-05-09T16:36:11Z] <taavi> delegated beta.toolforge.org domain to toolsbeta per T257386

Change 917927 had a related patch set uploaded (by Majavah; author: Majavah):

[cloud/toolforge/ingress-admission-controller@master] deployment: allow beta.toolforge.org in toolsbeta

https://gerrit.wikimedia.org/r/917927

Change 917927 merged by jenkins-bot:

[cloud/toolforge/ingress-admission-controller@master] deployment: allow beta.toolforge.org in toolsbeta

https://gerrit.wikimedia.org/r/917927