Page MenuHomePhabricator

Add tools to DiscussionTools' source mode
Closed, ResolvedPublic

Description

This task is about adding a yet-to-be defined set of tools to the Reply and New Discussion tool's source mode.

Note: adding tools to the DiscussionTools' source mode depends on changes being made to the source mode's "editing surface".

Tool ideas

This sections contains a living list of tools we ought to consider adding.

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ppelberg renamed this task from Add tools to Reply tool's source mode to Add tools to DiscussionTools' source mode.Jul 8 2020, 12:33 AM
ppelberg updated the task description. (Show Details)
ppelberg updated the task description. (Show Details)
JTannerWMF moved this task from Untriaged to Freezer on the Editing-team board.
JTannerWMF added a subscriber: JTannerWMF.

We will revisit the priority of this task if we receive more reports of users requesting this functionality

This user wants this functionality! At least give us the keyboard shortcuts.

We will revisit the priority of this task if we receive more reports of users requesting this functionality

@JTannerWMF It can be useful also for me.

ppelberg added a subscriber: Urbanecm.

We will revisit the priority of this task if we receive more reports of users requesting this functionality

@JTannerWMF It can be useful also for me.

@Patriccck is there a particular tool or tools you had in mind when writing the above? E.g. being able to access a tool like the visual mode's pinging feature?

Task description update
I've updated the task description to include the feedback user:ネイ shared at mw.org here: https://w.wiki/chN.

We will revisit the priority of this task if we receive more reports of users requesting this functionality

@JTannerWMF It can be useful also for me.

@Patriccck is there a particular tool or tools you had in mind when writing the above? E.g. being able to access a tool like the visual mode's pinging feature?

Sorry for a late reply. I had in mind pinging and also italic, bold, link and another.

ppelberg updated the task description. (Show Details)
ppelberg added a subscriber: Atmark-chan.
ppelberg edited projects, added Editing-team (Tracking); removed Editing-team.
ppelberg moved this task from Backlog to FY2020-21 on the Editing-team (Tracking) board.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

Change 628932 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Support the enable2017Wikitext option

https://gerrit.wikimedia.org/r/628932

Cool! One (likely) bug: if I press the reply button multiple times, it adds multiple @s.

Cool! One (likely) bug: if I press the reply button multiple times, it adds multiple @s.

Thanks, filed as T275906

Change 628932 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Support the enable2017Wikitext option

https://gerrit.wikimedia.org/r/628932

This is not enabled for Wikimedia wikis yet. We will need to make a config change to set $wgDiscussionToolsEnable2017Wikitext = true;.

Next step

Next step

The rough plan [i] is as follows:

#ActionPurposeTicket
1.Offer the source mode with tools as an opt-in setting for everyone who has DT enabled1) Verify people who have expressed interest in this new mode functions as they expect it to. 2) Determine whether people who start using the new mode continue using it.T276608
2.Offer source mode with tools as an opt-out setting for some of the people who have DT enabled1) Identify and address edge cases. 2) Determine whether the source mode with tools has parity with the existing source mode.T276609
3.Converge on a single source mode with tools within DiscussionTools1. Increase the maintainability of Discussion Tools Note: this step assumes no blocking issues surface in "Step 1." and "Step 2."T276607

i. This plan will no longer be rough after we have talked about this as a team next week (the week of 8-March).

To clarify from our discussion last week, we can't switch form opt-in to opt-out with the same setting. For users who have the preference set to "disabled" we have no way of knowing if they have deliberately turned off the tool, or if they just haven't seen the setting yet. To take this approach we will need to use two settings over time (i.e. the value of the opt-in setting will be ignored when we switch to opt-out).

Why can't there be three options "Enabled", "Disabled", and "Default", to separate users who deliberately turned off the tool from those that hadn't seen the settings?

Why can't there be three options "Enabled", "Disabled", and "Default", to separate users who deliberately turned off the tool from those that hadn't seen the settings?

I wouldn't want to offload that complexity on to the user, but we can see if there is a way to achieve that transparently (i.e. record if the user has turned the feature on then off again).

... we can see if there is a way to achieve that transparently (i.e. record if the user has turned the feature on then off again).

@Esanders: can you please give T276635 a read and edit anything I might've missed/misconstrued?

Another request from user @Ijoe2003 here.

Thank you for adding this, @Patriccck !

@Esanders: would it be accurate for me to think the following?

  1. This task can be resolved because the code that enables the new "source mode with tools" functionality has already been deployed
  2. The new "source mode with tools" functionality, and its associated setting, will not be visible to anyone on any production wiki until T275950 is deployed.

I think that's accurate.

Great – thank you, @matmarex.