Similar to T257356
I'm upgrading a wiki farm from 1.30.X to 1.34.X, and finding that a database patch introduced in the 1.34.X releases appears to break the update.
This occurs when upgrading from 1.33 or from 1.30.
I've narrowed it down to lines 11-14 in maintenance/archives/patch-drop-user-fields.sql
ALTER TABLE /*_*/ipblocks DROP COLUMN ipb_by, DROP COLUMN ipb_by_text, ALTER COLUMN ipb_by_actor DROP DEFAULT;
This doesn't appear to be performing a check to see if the table is shared, and is performed even when --doshared is not specified. It will run successfully for the first wiki to be upgraded, but all subsequent runs on wikis which share that table will fail with the MySQL error that column ipb_by does not exist.
Checking the ipblocks table local to the wiki reveals the ipb_by column is present, so perhaps this operation is supposed to run against the local table and is being inadvertantly run against the shared table.
It occurs whether the --doshared flag is specified or not.
I can resolve the error by running the update script once to perform the ALTER operation to the shared table, then commenting out the lines specified above for subsequent runs.