Page MenuHomePhabricator
Create Task
Maniphest T257477

Preview fails when $wgRawHtml is activated
Closed, ResolvedPublic
Actions

Description

When $wgRawHtml is true, the preview in forms fails with the MediaWiki error message session_fail_preview_html (expanded below).

It should be still a bit investigated but the edit token (classically wpEditToken) is probably not provided, perhaps in an internal FauxRequest - I see there are such things in PF_AutoeditAPI.php - but there is such token provided in the API POST request action=pfautoedit, so possibly some link is missing somewhere to pass this token internally.

I’m not sure if it is linked to T189812, the patch provided there did not improved the effects of the current bug.

session_fail_preview_html
Sorry! We could not process your edit due to a loss of session data.
Because {{SITENAME}} has raw HTML enabled, the preview is hidden as a precaution against JavaScript attacks.
If this is a legitimate edit attempt, please try again. If it still does not work, try [[Special:UserLogout|logging out]] and logging back in, and check that your browser allows cookies from this site.

Versions:

  • PageForms: 4.9.3 - 02485334b54
  • MediaWiki: 1.34.1 - 65e25dd3e98

Related Objects

Event Timeline

Seb35 created this task.Jul 8 2020, 4:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2020, 4:28 PM
Seb35 updated the task description. (Show Details)Jul 8 2020, 4:36 PM
Seb35 mentioned this in T189812: PF_AutoeditAPI.php logs users out on MediaWiki 1.27+ that use the AuthManager and SessionManager API..Jul 8 2020, 4:52 PM
Yaron_Koren closed this task as Resolved.Apr 25 2023, 8:20 PM
Yaron_Koren claimed this task.
Yaron_Koren added a subscriber: Yaron_Koren.

I just tried this, and can't duplicate the problem - I'm guessing it was fixed in MediaWiki a while ago.

Seb35 added a comment.Sep 27 2023, 8:35 AM

For the record, I found the solution and it is unrelated to PageForms.

It occurs systematically when the EditPage stays open for more than 1h and when $wgRawHtml is true. This delay corresponds to $wgObjectCacheSessionExpiry (default 1h, it is the delay the server keeps the session details before purging it), so it can be solved by increasing this delay.

Yaron_Koren added a comment.Sep 27 2023, 12:53 PM

Very interesting - thats good to know.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL