Page MenuHomePhabricator

Adding/editing descriptions should modify the local article, not Wikidata
Open, MediumPublic1 Estimated Story Points

Description

NB: All of this applies only to English Wikipedia.

This is to document the logic and behavior proposed so far, and to discuss potential changes, caveats, and edge cases. The basic behavior is as follows:

  • If an article already contains the {{short description}} template, we will parse the template and replace the text in the template with the new text supplied by the user.
  • If the article does not contain the {{short description}} template, we will insert the template at the top of the article, with the text supplied by the user.
  • If the article uses a template that generates a short description automatically (e.g. {{Infobox settlement}} among others), we will still make the description editable, and will explicitly insert a new {{short description}} template at the top, which will override any implicit short description generated by another template.

Possible pitfalls / other questions:

  • Is it possible for the description itself to contain wikitext and/or transclude other templates? If so, how should we handle those cases? Is there an example of an article that does this?
  • Is the name {{short description}} guaranteed to remain the official name of this template? Are there other names/aliases of this template that do the same thing?

Event Timeline

Charlotte created this task.Jul 8 2020, 5:39 PM
Dbrant renamed this task from Switch SE to suggest and modify local descriptions on enwiki to Adding/editing descriptions should modify the local article, not Wikidata.Jul 8 2020, 9:21 PM
Dbrant updated the task description. (Show Details)

Tagging @Tgr to look over the bullet points above and provide any other insights or precautions, and @Johan for visibility and possible community-facing discussions, and adding iOS folks since I believe they have the same feature that will need similar updates.

Johan added a comment.Jul 8 2020, 9:49 PM

Making sure: This is general editing and not the suggested edits feature?

There are aliases, but the documentation is very clear that they should not be used and points to gadgets and other templates assuming one template name.

Making sure: This is general editing and not the suggested edits feature?

It will be both.

Making sure: This is general editing and not the suggested edits feature?

The description editing UI is the same regardless of whether the user came from Suggested Edits or the general article edit-pencil. The Suggested Edits feature presents articles that don't have a description (neither local nor Wikidata), therefore edits resulting from Suggested Edits will always be adding {{short description}} at the top.

LGoto removed a project: Epic.Jul 13 2020, 6:42 PM
LGoto moved this task from Needs Triage to Tracking on the Wikipedia-iOS-App-Backlog board.
Charlotte triaged this task as High priority.Jul 14 2020, 4:11 PM
Johan added a comment.EditedJul 14 2020, 6:09 PM

I've pinged Wikipedia talk:Short descriptions to give the editors there an early heads-up and make sure we don't take them by surprise. Since I'll be OoO for the next few weeks, I've recommended that they ask any questions or give any feedback in this task, if possible.

I've pinged Wikipedia talk:Short descriptions to give the users there an early heads-up and make sure we don't take them by surprise. Since I'll be OoO for the next few weeks, I've recommended that they ask any questions or give any feedback in this task, if possible.

Cheers @Johan - have a good holiday!

Tgr added a comment.Jul 14 2020, 7:56 PM

As a specification, this looks reasonable, although it doesn't explain what is going to do this and how.

Note that the local template overriding the infobox only works if the parser function call in the infobox is marked up correctly (T193857). I expect the community is managing that so you won't encounter any problems, just an FYI.

Is it possible for the description itself to contain wikitext and/or transclude other templates? If so, how should we handle those cases? Is there an example of an article that does this?

There isn't really any mechanism for preventing editors from putting anything anywhere (the parser could return an error on save, but can't really differentiate between errors in the article wikitext and errors in some template, so it would be problematic and is not used much for normal pages), so it's technically valid, and back when I wrote the API, it was still debated whether it should be done (see discussion here). The API will display it as-is though, without any wikitext parsing (with only minimal sanitization).

Transcluding other templates is entirely possible (although I'd imagine it's not done in practice).

As a specification, this looks reasonable, although it doesn't explain what is going to do this and how.

See the proposal(s) in T257944

kaldari added a subscriber: kaldari.Aug 4 2020, 4:59 PM

@Dbrant @Tgr - Is this something that the Core Platform Team can help with or is it being handled already within the Product department? If it's already being handled, what is the estimated timeframe? In other words, when do you expect this to no longer block T256817?

@kaldari I believe the Core Platform team is looking at handling this task (cc @EvanProdromou for timeframes)

eprodromou added a subscriber: eprodromou.

I think we've got this on our roadmap discussion, so I'm going to untag the Platform inbox and we'll get this moving.

Charlotte lowered the priority of this task from High to Medium.Aug 10 2020, 2:11 PM

@eprodromou - I'm a bit confused. Usually untagging a team means you are disclaiming responsibility for it, not claiming responsibility for it.

@Dbrant - If you're not working on this, is it OK if I remove you as the assignee?

Dbrant removed Dbrant as the assignee of this task.Aug 10 2020, 8:27 PM

yep!

Pppery added a subscriber: Pppery.Aug 24 2020, 3:54 AM
Naike set the point value for this task to 1.Sep 11 2020, 10:48 AM