Page MenuHomePhabricator

toolforge needs git-review 1.27+ to work with new Gerrit deploy
Closed, ResolvedPublic

Description

Gerrit 3.2 requires git-review 1.27+, but Toolforge bastions have 1.25 installed:

[taavi@tools-sgebastion-07 ~] $ apt show git-review
Package: git-review
Version: 1.25.0-2
Priority: extra
Section: python
Maintainer: PKG OpenStack <openstack-devel@lists.alioth.debian.org>
Installed-Size: 138 kB
Depends: git, python, python-requests, python:any (<< 2.8), python:any (>= 2.7.5-5~)
Homepage: http://docs.openstack.org/infra/git-review/
Download-Size: 31.1 kB
APT-Manual-Installed: yes
APT-Sources: http://deb.debian.org/debian stretch/main amd64 Packages
Description: git command for submitting branches to Gerrit
 git-review is a tool that helps submitting git branches to gerrit for review.
 It is used extensively for the development and maintenance of OpenStack, but
 it can be used for any project using Gerrit.

Event Timeline

bd808 renamed this task from toolforge should have a working version of git-review to toolforge needs git-review 1.27+ to work with new Gerrit deploy.Jul 8 2020, 7:05 PM
bd808 edited projects, added Toolforge (Software install/update); removed Toolforge.

We will need to backport the git-review package from Buster to reach a working version -- https://packages.debian.org/search?keywords=git-review

As a workaround, people can use pip in a venv for git-review.

I tried to re-build git-review 1.27 for stretch on deneb.

I ran into the issue: "Could not find suitable distribution for Requirement.parse('pbr')" ( https://docs.openstack.org/pbr/latest/)

It looks like it needs a newer version of pbr than is available in stretch.

Then talked to Moritz and proceeded with trying to simply install the buster package on a stretch machine (mwdebug1001) which worked fine.

Then i included the 1.27 deb with reprepro "includedeb" to our APT repo. So:

apt1001:~] $ sudo -i reprepro -C main includedeb stretch-wikimedia /tmp/git-review_1.27.0-1_all.deb 
Exporting indices...


[apt1001:~] $ sudo -i reprepro ls git-review
git-review | 1.27.0-1 | stretch-wikimedia | amd64, i386

I removed the package from mwdebug1001 again and installed it with apt-get install to confirm. It works.

You should be able to get the new version on stretch hosts now.

This now needs someone to install it (the right way) on the toolforge bastions.

(fwiw, this also made us realize this exists on some stat* hosts with the same problem)

Mentioned in SAL (#wikimedia-cloud) [2020-07-09T18:53:54Z] <bd808> Updating git-review to 1.27 via clush across cluster (T257496)

bd808 assigned this task to Dzahn.
tools-sgebastion-08.tools:~$ apt show git-review
Package: git-review
Version: 1.27.0-1
Priority: optional
Section: vcs
Maintainer: Debian OpenStack <team+openstack@tracker.debian.org>
Installed-Size: 161 kB
Depends: git, python3-requests, python3:any
Homepage: http://docs.openstack.org/infra/git-review/
Download-Size: 35.8 kB
APT-Manual-Installed: yes
APT-Sources: http://apt.wikimedia.org/wikimedia stretch-wikimedia/main amd64 Packages
Description: git command for submitting branches to Gerrit
 git-review is a tool that helps submitting git branches to gerrit for review.
 It is used extensively for the development and maintenance of OpenStack, but
 it can be used for any project using Gerrit.

N: There is 1 additional record. Please use the '-a' switch to see it