Page MenuHomePhabricator

Call to a member function getRevertTags() on null
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

MediaWiki version: 1.35.0-wmf.39

message
Call to a member function getRevertTags() on null

Impact

production logspam

Notes

Details

Request ID
8683ed53-7d10-4e7e-bf0e-34f4e4fb8303
Request URL
https://www.wikidata.org/w/index.php?title=Q18479578&action=rollback&from=2804%3A14C%3A5BB3%3AA319%3A199D%3ABE00%3A6E42%3AA58D&token=73608e50a1dadf28653562de0046dfa85f05e30e%2B%5C
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.35.0-wmf.39/includes/page/WikiPage.php(3231): WikiPage->commitRollback(string, string, boolean, NULL, User, NULL)
#1 /srv/mediawiki/php-1.35.0-wmf.39/includes/actions/RollbackAction.php(124): WikiPage->doRollback(string, string, string, boolean, NULL, User)
#2 /srv/mediawiki/php-1.35.0-wmf.39/includes/actions/RollbackAction.php(87): RollbackAction->handleRollbackRequest()
#3 /srv/mediawiki/php-1.35.0-wmf.39/includes/MediaWiki.php(527): RollbackAction->show()
#4 /srv/mediawiki/php-1.35.0-wmf.39/includes/MediaWiki.php(313): MediaWiki->performAction(Article, Title)
#5 /srv/mediawiki/php-1.35.0-wmf.39/includes/MediaWiki.php(986): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.35.0-wmf.39/includes/MediaWiki.php(543): MediaWiki->main()
#7 /srv/mediawiki/php-1.35.0-wmf.39/index.php(53): MediaWiki->run()
#8 /srv/mediawiki/php-1.35.0-wmf.39/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Event Timeline

mmodell created this task.Jul 8 2020, 6:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2020, 6:46 PM

PageUpdater::getEditResult() is clearly documented to return null. But in this case, apart from the unchecked call it's also being done too early.

Change 610353 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Make EditResult::getRevertTags() call to be only when the update was successful

https://gerrit.wikimedia.org/r/610353

Ammarpad claimed this task.Jul 8 2020, 7:41 PM

Change 610353 merged by jenkins-bot:
[mediawiki/core@master] Make EditResult::getRevertTags() call to be only when the update was successful

https://gerrit.wikimedia.org/r/610353

Umherirrender closed this task as Resolved.Jul 10 2020, 7:44 PM