Page MenuHomePhabricator

Make the maps object editable from the TempateData dialog
Closed, ResolvedPublic

Description

Following T254478: Create the initial UI of Maps panel in TemplateData GUI, the TemplateData dialog now has a maps panel, with a multiline text input widget containing the maps object as a JSON string. The text input widget is disabled.

This task is for enabling the text input widget and making the JSON editable. (Changing the format to something simpler than JSON will be done in a future task.)

Acceptance criteria:

  • The multiline text input is enabled
  • As the user types, the "Done" action becomes disabled is the JSON is invalid
  • As the user types, the "Done" action becomes enabled if the JSON is valid
  • On clicking the "Done" action, then the "Apply" action, the changes appear in the wikitext area when the dialog closes
  • On clicking the "Cancel" action, the model will revert to the state before the maps panel was opened, any changes will be discarded

Event Timeline

Tchanders renamed this task from Draft: Make the maps object editable from the TempateData dialog to Make the maps object editable from the TempateData dialog.Jul 10 2020, 10:45 AM

Change 611903 had a related patch set uploaded (by AdhamKhatean; owner: AdhamKhatean):
[mediawiki/extensions/TemplateData@master] Make the maps object editable from the TemplateData dialog

https://gerrit.wikimedia.org/r/611903

Change 611903 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Make the maps object editable from the TemplateData dialog

https://gerrit.wikimedia.org/r/611903