Develop OAuthRateLimiter extension
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• Pchelolo
	Jul 9 2020, 6:28 PM

Description

In order to manage the rate limits for clients and provide them to the access tokens in the OAuth extension we need to develop a separate extension, that would hold the rate limits logic. MVP functionality:

Implement the OAuth hook to provide the claims
Database table to store the mapping between client ID and client class
Configuration for mapping between client classes and rate limits
Maintenance script to assign clients to classes

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Implement OAuth hook & add functionality to set/get ratelimit tiers	mediawiki/extensions/OAuthRateLimiter	master	+828 -20
Initial commit	mediawiki/extensions/OAuthRateLimiter	master	+466 -0
Add CI to OAuthRateLimiter extension	integration/config	master	+9 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• eprodromou	T235270 Wikimedia API Gateway
Resolved	• eprodromou	T255030 Wikimedia API Gateway MVP
Resolved	• Pchelolo	T246271 Administrator defines rate limit classes
Resolved	None	T257607 Develop OAuthRateLimiter extension
Resolved	• Pchelolo	T258423 Deploy OAuthRateLimiter extension to Wikimedia Production
Resolved	• Kormat	T258711 Review request for a new database table for OAuthRateLimiter
Resolved	• Gilles	T258824 Performance review of OAuthRateLimiter
Resolved	Reedy	T257930 Security Readiness Review For OAuthRateLimiter
Resolved	Reedy	T260587 Security Readiness Review For Wikimedia/oauth2-server
Resolved	Reedy	T260588 Security Readiness Review For Adding Private Claims To OAuth Extension

Event Timeline

• Pchelolo created this task.Jul 9 2020, 6:28 PM

Repository requested: https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests

The Repo got created yesterday

https://www.mediawiki.org/w/index.php?title=Gerrit/New_repositories/Requests/Entries&diff=3960335&oldid=3957958

Change 612364 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[integration/config@master] Add CI to OAuthRateLimiter extension

https://gerrit.wikimedia.org/r/612364

gerritbot added a project: Patch-For-Review.Jul 13 2020, 3:24 PM

Change 612364 merged by jenkins-bot:
[integration/config@master] Add CI to OAuthRateLimiter extension

https://gerrit.wikimedia.org/r/612364

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2020, 9:10 PM

Change 612361 had a related patch set uploaded (by Ppchelko; owner: Clarakosi):
[mediawiki/extensions/OAuthRateLimiter@master] Initial commit

https://gerrit.wikimedia.org/r/612361

gerritbot added a project: Patch-For-Review.Jul 13 2020, 9:30 PM

Change 612361 merged by jenkins-bot:
[mediawiki/extensions/OAuthRateLimiter@master] Initial commit

https://gerrit.wikimedia.org/r/612361

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2020, 4:10 PM

Change 613282 had a related patch set uploaded (by Clarakosi; owner: Clarakosi):
[mediawiki/extensions/OAuthRateLimiter@master] Implement OAuth hook & add functionality to set/get ratelimit tiers

https://gerrit.wikimedia.org/r/613282

gerritbot added a project: Patch-For-Review.Jul 22 2020, 10:33 PM

QChris unsubscribed.Jul 23 2020, 1:17 PM

• Pchelolo added a project: MediaWiki-extensions-OAuthRateLimiter.Jul 23 2020, 7:19 PM

• Clarakosi added a subtask: T258824: Performance review of OAuthRateLimiter.Jul 24 2020, 7:08 PM

• Clarakosi added a subtask: T257930: Security Readiness Review For OAuthRateLimiter.

• WDoranWMF added a project: Platform Team Workboards (Green).Jul 24 2020, 7:46 PM

• WDoranWMF moved this task from Backlog to Waiting for Review on the Platform Team Workboards (Green) board.

• WDoranWMF added a project: Platform Team Sprints Board (Sprint 0).

• WDoranWMF moved this task from Waiting for Review to Blocked on the Platform Team Workboards (Green) board.Aug 6 2020, 6:04 PM

Naike edited projects, added Platform Team Sprints Board (Sprint 1); removed Platform Team Sprints Board (Sprint 0).Aug 7 2020, 10:43 AM

@Pchelolo - Why is this ticket blocked? How can we unblock it?

• Gilles closed subtask T258824: Performance review of OAuthRateLimiter as Resolved.Aug 10 2020, 10:17 AM

Naike edited projects, added Platform Team Sprints Board (Sprint 2); removed Platform Team Sprints Board (Sprint 1).Aug 21 2020, 1:27 PM

Reedy closed subtask T257930: Security Readiness Review For OAuthRateLimiter as Resolved.Aug 27 2020, 9:41 PM

• Pchelolo moved this task from Blocked to Ready to Deploy on the Platform Team Workboards (Green) board.Aug 27 2020, 9:43 PM

Change 613282 merged by jenkins-bot:
[mediawiki/extensions/OAuthRateLimiter@master] Implement OAuth hook & add functionality to set/get ratelimit tiers

https://gerrit.wikimedia.org/r/613282

Maintenance_bot removed a project: Patch-For-Review.Aug 27 2020, 10:10 PM

• Kormat closed subtask T258711: Review request for a new database table for OAuthRateLimiter as Resolved.Sep 3 2020, 7:41 AM