Add specific class to Score error box
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tacsipacsi
	Jul 9 2020, 8:21 PM

Description

Until T257066 is fixed, projects may want to hide Score’s error boxes (e.g. request on frwiki). Currently such CSS rules can only target .errorbox, which may accidentally hide other error boxes, no matter how specific they are. There should be a specific class like .mw-ext-score-error as well, which can be safely targeted with on-site CSS, and ideally this should be deployed ASAP so that projects don’t create vague CSS rules.

Details

Subject	Repo	Branch	Lines +/-
Make Score errors use a specific css class	mediawiki/extensions/Score	REL1_34	+2 -2
Make Score errors use a specific css class	mediawiki/extensions/Score	REL1_31	+3 -2
Make Score errors use a specific css class	mediawiki/extensions/Score	wmf/1.35.0-wmf.40	+2 -2
Make Score errors use a specific css class	mediawiki/extensions/Score	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T257062: Lilypond seemingly not subject to restrictions (CVE-2020-29007)
Mentioned Here: T257066: Extension:Score / Lilypond is disabled on all wikis

Event Timeline

Tacsipacsi created this task.Jul 9 2020, 8:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 9 2020, 8:21 PM

Change 610967 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Score@master] Make Score errors use a specific css class

https://gerrit.wikimedia.org/r/610967

gerritbot added a project: Patch-For-Review.Jul 9 2020, 11:32 PM

Tacsipacsi updated the task description. (Show Details)Jul 9 2020, 11:36 PM

Change 610967 merged by jenkins-bot:
[mediawiki/extensions/Score@master] Make Score errors use a specific css class

https://gerrit.wikimedia.org/r/610967

@Reedy Thanks for the patch! Is there any chance to get this deployed today? I know WMF employees want to enjoy the weekend, but volunteers enjoy the weekend by editing Wikipedia and might create inferior CSS rules to work around this issue before Monday.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 10 2020, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2020, 9:10 AM

Change 611217 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Score@wmf/1.35.0-wmf.40] Make Score errors use a specific css class

https://gerrit.wikimedia.org/r/611217

gerritbot added a project: Patch-For-Review.Jul 10 2020, 11:58 AM

Change 611217 merged by Reedy:
[mediawiki/extensions/Score@wmf/1.35.0-wmf.40] Make Score errors use a specific css class

https://gerrit.wikimedia.org/r/611217

In T257623#6296096, @Tacsipacsi wrote:

@Reedy Thanks for the patch! Is there any chance to get this deployed today? I know WMF employees want to enjoy the weekend, but volunteers enjoy the weekend by editing Wikipedia and might create inferior CSS rules to work around this issue before Monday.

Done!

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.40; 2020-07-07); removed MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 10 2020, 1:00 PM

In T257623#6296668, @Reedy wrote:

In T257623#6296096, @Tacsipacsi wrote:

@Reedy Thanks for the patch! Is there any chance to get this deployed today? I know WMF employees want to enjoy the weekend, but volunteers enjoy the weekend by editing Wikipedia and might create inferior CSS rules to work around this issue before Monday.

Done!

Thanks!

Krinkle mentioned this in T257062: Lilypond seemingly not subject to restrictions (CVE-2020-29007).Jul 10 2020, 2:02 PM

Change 615766 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Score@REL1_34] Make Score errors use a specific css class

https://gerrit.wikimedia.org/r/615766

Change 615767 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Score@REL1_31] Make Score errors use a specific css class

https://gerrit.wikimedia.org/r/615767

Change 615767 merged by Reedy:
[mediawiki/extensions/Score@REL1_31] Make Score errors use a specific css class