| egardner | |
| Jul 9 2020, 10:46 PM |
| F32416856: Screen Shot 2020-10-27 at 3.10.39 PM.png | |
| Oct 27 2020, 10:34 PM |
| F32416850: Screen Shot 2020-10-27 at 2.48.20 PM.png | |
| Oct 27 2020, 10:34 PM |
| F32416848: Screen Shot 2020-10-27 at 2.36.28 PM.png | |
| Oct 27 2020, 10:34 PM |
| F32416854: Screen Shot 2020-10-27 at 3.02.50 PM.png | |
| Oct 27 2020, 10:34 PM |
| F32416846: Screen Shot 2020-10-27 at 2.47.24 PM.png | |
| Oct 27 2020, 10:34 PM |
| F32110150: image.png | |
| Aug 13 2020, 7:57 PM |
| F32110168: image.png | |
| Aug 13 2020, 7:57 PM |
| F32110164: image.png | |
| Aug 13 2020, 7:57 PM |
Replace the current HTML5 audio/video elements with the new tools for AV playback. Details TBD.
We've identified a few cross-browser issues with native audio/video elements:
Acceptance criteria:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add Player base component and use videoinfo API | mediawiki/extensions/WikibaseMediaInfo | master | +113 -47 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | egardner | T257637 [Epic] Use the latest MediaWiki audio/video player tools for multimedia playback in MediaSearch QuickView | |||
| Duplicate | • brion | T271388 MPEG video files lack thumbnail images | |||
| Resolved | Etonkovidova | T266842 Add ogv.js shim to enable Safari support for OGG and WEBP videos (in quickview) |
I'm not sure which code generates the HTML for these, but note that MediaWiki addresses this in articles through TimedMediaHandler (also exposed via the videoinfo API for lazy/late-loading contexts in JS). And the TimedMediaHandler extension also has the video.js player and ogv.js modules required for cross-browser compat and selection of the right media format.
/cc @brion
Change 628428 had a related patch set uploaded (by Eric Gardner; owner: Eric Gardner):
[mediawiki/extensions/WikibaseMediaInfo@master] Use videoinfo API for Audio/Video Quickview
Change 628428 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Add Player base component and use videoinfo API
@egardner - should it be moved to Ready for development? Or it should be in Blocked?
Checked in betalabs and production.
- .ogg files aren't supported natively in Safari, so for these files the audio player displays but does nothing, which is confusing
- At least some videos don't work in Safari.
betalabs example from the description
commonswiki wmf.14
| Safari 13 &12 |
|---|
| Video files type | Works? | Search terms | Example |
|---|---|---|---|
| webm | No | roads |  |
| mpg | Yes | roads |  |
| ogg | No | roads |  |
Note:
- audio and video elements aren't working in IE11:
Audio works in IE11; video doesn't.
commonswiki wmf.14
| IE 11 |
|---|
| Video files type | Works? | Search terms | Example |
|---|---|---|---|
| webm | No | roads | |
| mpg | No | roads |  |
| ogg | No | roads | |
File:How to Use SE Module.webm (in betalabs) can be played in IE11, but in production I could not find an example of a video file that would play in Quickview on Special:MediaSearch. Tenttively put the task as stalled (pending additional insights).
Per our conversation with @Ramsey-WMF and @MarkTraceur I split up this task into two tasks due to some updates after the testing and for easier prioritization.
T266831: IE 11 - video player does not work on MediaSearch page
T266842: Add ogv.js shim to enable Safari support for OGG and WEBP videos (in quickview)