Page MenuHomePhabricator

Investigate why core api tests fail on Wikibase CI jobs
Closed, ResolvedPublic

Description

Example output from mediawiki-quibble-apitests-vendor-docker #14146 for I62c520f826:

215 passing (55s)
1 pending
5 failing

1) Search
     GET /search/page?q={term}
       should return array of pages when there is only a text match:

    AssertionError: expected [] to have a length of 1 but got 0
    + expected - actual

    -0
    +1
    
    at Context.it (tests/api-testing/REST/Search.js:33:11)
    at process._tickCallback (internal/process/next_tick.js:68:7)

2) Search
     GET /search/page?q={term}
       should return array of pages when there is only title match:

    AssertionError: expected [] to have a length of 1 but got 0
    + expected - actual

    -0
    +1
    
    at Context.it (tests/api-testing/REST/Search.js:52:11)
    at process._tickCallback (internal/process/next_tick.js:68:7)

3) Search
     GET /search/page?q={term}
       should return a single page when there is a title and text match on the same page:

    AssertionError: expected [] to have a length of 1 but got 0
    + expected - actual

    -0
    +1
    
    at Context.it (tests/api-testing/REST/Search.js:63:11)
    at process._tickCallback (internal/process/next_tick.js:68:7)

4) Search
     GET /search/page?q={term}
       should return two pages when both pages match:

    AssertionError: expected [] to have a length of 2 but got 0
    + expected - actual

    -0
    +2
    
    at Context.it (tests/api-testing/REST/Search.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:68:7)

5) Search
     GET /search/page?q={term}
       should return only one page when two pages match but limit is 1:

    AssertionError: expected [] to have a length of 1 but got 0
    + expected - actual

    -0
    +1
    
    at Context.it (tests/api-testing/REST/Search.js:81:11)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Event Timeline

Tarrow created this task.Jul 10 2020, 8:53 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptJul 10 2020, 8:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Appears to be failing because in CI $wgWikimediaJenkinsCI = true; and Wikibase is loaded through extensions/Wikibase/Wikibase.php which results in repo/config/Wikibase.ci.php and client/config/WikibaseClient.ci.php being loaded

This causes: $wgDisableSearchUpdate = true. This breaks the API tests for search.

This setting appears to have been set during I121efff9d1 to remove either flaky tests or logspam or both when browser tests are impacted in some way by Cirrus updates.

The current plan is to add a new setting to CirrusSearch to allow just these updates to be disabled rather than across all of MW.

Change 612185 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/CirrusSearch@master] Add CirrusSearchDisableUpdate config option

https://gerrit.wikimedia.org/r/612185

Change 612185 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add CirrusSearchDisableUpdate config option

https://gerrit.wikimedia.org/r/612185