Page MenuHomePhabricator
Create Task
Maniphest T257658

Introduce new Repo entityterms API and remove hack from Client pageterms API
Closed, ResolvedPublic
Actions

Description

The WikibaseClient action=query&prop=pageterms API currently has special behavior on Repo wikis, where it returns the terms of the entity page instead of the terms of the entity linked to that page. We will introduce a new WikibaseRepo API module for this purpose, action=query&prop=entityterms, and then (after following the notification policy of the stable interface policy) remove that special behavior from the pageterms API.

Details

SubjectRepoBranchLines +/-
Remove repo hack from pageterms APImediawiki/extensions/Wikibasemaster+11 -30
Add entityterms Repo APImediawiki/extensions/Wikibasemaster+747 -136
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 10 2020, 9:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2020, 9:46 AM
Lucas_Werkmeister_WMDE mentioned this in T255882: Don’t use WikibaseRepo when initializing Client pageterms API.Jul 10 2020, 9:46 AM
Lucas_Werkmeister_WMDE claimed this task.Jul 10 2020, 10:27 AM
Lucas_Werkmeister_WMDE moved this task from Backlog to Doing on the Wikibase Extension Decoupling and Registration (Sprint 3) board.
gerritbot added a comment.Jul 10 2020, 11:31 AM

Change 611282 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Add entityterms Repo API

https://gerrit.wikimedia.org/r/611282

gerritbot added a project: Patch-For-Review.Jul 10 2020, 11:31 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 10 2020, 11:34 AM
Ladsgroup moved this task from Peer Review to Verification on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 13 2020, 3:40 PM
Ladsgroup moved this task from Verification to Doing on the Wikibase Extension Decoupling and Registration (Sprint 3) board.
gerritbot added a comment.Jul 13 2020, 3:52 PM

Change 611282 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add entityterms Repo API

https://gerrit.wikimedia.org/r/611282

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Jul 13 2020, 3:58 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 13 2020, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 13 2020, 4:10 PM
gerritbot added a comment.Jul 14 2020, 11:38 AM

Change 612549 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove repo hack from pageterms API

https://gerrit.wikimedia.org/r/612549

gerritbot added a project: Patch-For-Review.Jul 14 2020, 11:38 AM
Lucas_Werkmeister_WMDE changed the task status from Open to Stalled.Jul 15 2020, 4:24 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Backlog on the Wikibase Extension Decoupling and Registration (Sprint 3) board.

Stalled until wmf.2 has been branched (since we effectively announced the pageterms change would be deployed with wmf.3).

Lucas_Werkmeister_WMDE moved this task from Backlog to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Aug 3 2020, 3:58 PM
gerritbot added a comment.Aug 3 2020, 4:24 PM

Change 612549 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove repo hack from pageterms API

https://gerrit.wikimedia.org/r/612549

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Aug 3 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 3 2020, 5:10 PM
darthmon_wmde mentioned this in Wikibase Extension Decoupling and Registration (Sprint 4).Aug 4 2020, 8:15 AM
darthmon_wmde edited projects, added Wikibase Extension Decoupling and Registration (Sprint 4); removed Wikibase Extension Decoupling and Registration (Sprint 3).Aug 4 2020, 9:12 AM
darthmon_wmde moved this task from Backlog to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 4) board.
Lucas_Werkmeister_WMDE changed the task status from Stalled to Open.Aug 4 2020, 9:14 AM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikibase Extension Decoupling and Registration (Sprint 4) board.
Lucas_Werkmeister_WMDE closed this task as Resolved.Aug 7 2020, 1:54 PM
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikibase Extension Decoupling and Registration (Sprint 4) board.

Working as intended on Wikidata – pageterms of Wikidata:Project chat now returns “Project:Village pump”, entityterms of Q42 returns “Douglas Adams”.

Ladsgroup mentioned this in T281639: Special:Nearby not showing labels.Jun 1 2021, 9:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL