Page MenuHomePhabricator

Paragraph-based Edit Conflict Interface deletes answers on talk:pages
Open, Stalled, Needs TriagePublicBUG REPORT

Description

first described here: https://www.mediawiki.org/wiki/Topic:Vpt3g4xso7kmnqh5

problem
When used on talk:pages, the Paragraph-based Edit Conflict Interface deletes answer that have been added between one user opening the tool by running in a conflict and resolving the conflict.

Reproduce

  1. Create edit conflict on talk:page between two users
  2. Leave Paragraph-based Edit Conflict Interface open with one user. Do not resolve the conflict
  3. Enter more comments on the same talk:page with the user who does not have Interface open or a third user
  4. resolve the conflict from step 2 in Interface
  5. Comments from step 3 are deleted

Example
https://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Itti&diff=201718902&oldid=201718833

Impact
Deleting other peoples comments leads to Appealing a block
Users who work with Paragraph-based Edit Conflict Interface are more likely to be blocked
In cases where the problem with the interface is detected, the community asks members to deactivate the interface

Event Timeline

Rost_WMDE changed the subtype of this task from "Task" to "Bug Report".Jul 10 2020, 10:21 AM

For your information, I gave this a quick try, but was not able to reproduce the issue. This does not mean there is no bug, I was just not able to reproduce it yet. I think I followed the instructions given in the task description. Nothing is deleted. Depending on where the other edits (by the 3rd user) are made, clicking save either brings up another edit conflict, or resolves everything just fine. Both is expected behavior.

Possibly related: T246726: Prevent data loss in DiscussionTools caused by MediaWiki not detecting edit conflicts with yourself (also see https://www.mediawiki.org/wiki/Topic:Vhgb6y8dqm58yjni for a discussion about this issue).

We will certainly investigate this further. @Seewolf, can you try to explain how you run into the issue?

Lena_WMDE set the point value for this task to 2.Jul 22 2020, 8:16 AM

Points for investigation of this issue.

awight moved this task from Sprint Backlog to Watching on the WMDE-QWERTY-Sprint-2020-07-22 board.

I'll look at records of the conflicts and editing sessions linked to, and try variations of the steps to reproduce. Two striking details mentioned in the thread are that the conflicting edit was made 10 hours after the previous—time for "thinking"—and that the edit is said to have come from a Diff view.

WMDE-Fisch moved this task from Review to Doing on the WMDE-QWERTY-Sprint-2020-10-21 board.
WMDE-Fisch subscribed.

Sorry moved wrong ticket ^^'

There are three examples given in the discussions:

There are detailed logs of other conflicts on these pages during July, but nothing is logged for first two examples here. I suggest looking for more clues in the direction of editing directly from the diff view, or other unusual behaviors.

I can find logs for the third example. What we know:

  • The conflict was exactly as it appears. The two users started with base revision ID 201718735, an edit 201718833 was made, the conflict was resolved as revision 201718902 .
  • The conflict workflow was entered exactly once, but the conflict page was reloaded three times.
  • The conflicting user's browser never sent any logs about the workflow. There should have been a corresponding "exit" event for each time the conflict workflow was reopened, but zero were recorded. This might be explained by an adblocker interfering.

In other words, there isn't much I can say about this third example other than, the conflict workflow was entered. Unfortunately, the other detailed log streams I might have been able to use for debugging only date back to August 4th, I've waited too long to investigate this bug.

It's asking a lot, but perhaps the original reporters can try to reproduce this with the adblocker turned off...

awight changed the task status from Open to Stalled.Nov 2 2020, 2:00 PM
awight moved this task from Incoming to Watching or blocked on the WMDE-TechWish-Maintenance board.

Waiting for more information.

awight removed awight as the assignee of this task.Nov 2 2020, 5:03 PM