Page MenuHomePhabricator

Add a configuration flag for swapping the client experience for Vue.js search
Closed, ResolvedPublic3 Estimated Story Points

Description

T250851 enabled the client search experience to be swapped in Core. T257647 makes the new client experience available. This task captures the work to add a configuration that swaps between the old and the new.

Acceptance criteria

  • A new search client configuration flag is added for Latest mode (version 2) only. When set, the new search client experience is loaded. When unset, the existing search client experience is loaded. Note: this flag has nothing to do with the position of search which is determined by the server render and identical for both client experiences. This flags changes only the JavaScript and styles that are loaded. This can use the feature manager if it makes sense.
  • Regardless of configuration, Legacy mode operates the same.
  • The flag must be overridable by URI query parameter so that we can QA Search on the Beta Cluster and the initial deployment wikis.
  • T249297 is revised to include deployment instructions and a patch (-2'd initially).

Event Timeline

@Peter.ovchyn, this may be a good task for you so that we can merge https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/612570 to master without any impact to Latest or Legacy mode.

The new search experience is not ready yet. This task can use the old search experience for both off and on configuration states (a no-op) but should be designed so that adding the new search implementation later is close to a one-line module name change. /cc @Jdlrobson

Change 612570 had a related patch set uploaded (by Jdlrobson; owner: Peter.ovchyn):
[mediawiki/skins/Vector@master] Vector manages search functionality and provides config flag

https://gerrit.wikimedia.org/r/612570

Waiting for some guidance from Mr Vue Search himself Stephen! :)

Change 612570 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Vector manages search functionality and provides config flag

https://gerrit.wikimedia.org/r/612570

Jdlrobson updated the task description. (Show Details)