Page MenuHomePhabricator

Revise how Reply tool behaves when ":" is typed in its visual mode
Closed, ResolvedPublic

Description

This task is about revising how the Reply tool behaves when : is typed in its visual mode.

Background

As @Ciell reported here [i], it is unexpected that typing : in the Reply tool's visual mode will create a <blockquote>...</blockquote> considering that on talk pages, the : is commonly understood to cause a comment to be indented.

Implementation details

This section will be filled with an approach once it's decided upon.

Approaches

Approach 1: do not support : as indentation syntax in the tool's visual mode

  • When someone types : in the Reply tool's visual mode the following should happen:
    • : should appear in the tool's text input area
    • A hint should be shown that makes it clear to people that the tool's visual mode does not support Wikitext AND if they want to use Wikitext markup, they will need to use the tool's source mode.
  • When someone switches to the tool's source mode after having typed : in the tool's visual mode, they should see:
    • <nowiki>:</nowiki>

Approach 2: treat : as indentation syntax in the tool's visual mode [i]

  • When someone types : in the Reply tool's visual mode the following should happen:
    • The line they placed the : in front of should be visuall indented
  • When someone switches to the tool's source mode after having typed : in the tool's visual mode, they should see:
    • : in the position where they typed in the tool's visual mode
  • When someone switches back to the tool's visual mode from its source, they should see:
    • The line they placed the : in front of should be visually indented as it had been when they originally typed it.

Open questions

  • 1. What would an approach (Approach 2) look like that honors what the person is in this case is trying to do: indent their comment further?

Done

  • All "Open questions" are answered
  • The "Implementation details" are implemented

i. ⚠️This has not yet been discussed with Engineering.

Event Timeline

As a short-term fix, could we disable the : shortcut to blockquote tags as soon as possible? That's almost always the wrong answer on a talk page. We can live with whatever would happen if that shortcut had never been set up while we talk about the ideal outcome.

As a short-term fix, could we disable the : shortcut to blockquote tags as soon as possible? That's almost always the wrong answer on a talk page. We can live with whatever would happen if that shortcut had never been set up while we talk about the ideal outcome.

Good call and agreed. Filed: T258194.

We ended up implementing "approach 1" with T258194 and T274923, so I think we should close this.

ppelberg claimed this task.

We ended up implementing "approach 1" with T258194 and T274923, so I think we should close this.

Good spot. Sounds good.