Page MenuHomePhabricator

rebuildFileCache.php should rebuild all pages rather than just content pages
Closed, ResolvedPublic

Description

The maintenance script rebuildFileCache.php only rebuilds the file cache for content pages, but that is an odd choice since File Caching applies to all pages.

I want to propose that we either:

  • Make the script run for all pages.
  • Add an option, --all.

Would there be any reason not to go with the first option? I can't really imagine it breaking anyone's setup, if anything this would just be helpful for those editor inadvertently serving old pages from the project namespace.

Event Timeline

Egill created this task.Jul 11 2020, 8:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2020, 8:22 AM
Restricted Application added a project: Commons. · View Herald TranscriptJul 11 2020, 8:29 AM
Reedy added a subscriber: Reedy.Jul 11 2020, 11:49 AM

I suspect it's a case that Content Pages are expected to be higher traffic, and therefore there's more benefit from having caches for them...

Change 611719 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Give rebuildFileCache.php an all pages option

https://gerrit.wikimedia.org/r/611719

Change 611719 merged by jenkins-bot:
[mediawiki/core@master] Give rebuildFileCache.php an all pages option

https://gerrit.wikimedia.org/r/611719

Reedy closed this task as Resolved.Jul 12 2020, 1:29 PM
Reedy claimed this task.