Page MenuHomePhabricator

Automatically alter entitysources configuration for values for fed props when pointing at
Closed, ResolvedPublic


For Wikibases with federation enabled to

  • Automatically alter entitysources configuration to use values for properties
  • No intervention from the user necessary

T253868 includes some details about this entity sources config (and it is still being discussed in matter most)

The config that we would look for to assume that is being referred to, and thus set this entity sources config would be:

'federatedPropertiesSourceScriptUrl' => '',

Code pointers:
WikibaseRepo::getEntitySourceDefinitionsFromSettings creates the definitions object from config for repo. This will likely need to know somehow if it should add our fed props entity source. This could be done by altering the config parser, or altering the config we pass into the parser.
EntitySourceDefinitionsConfigParser is the "modern" config parser that we want to alter.
It is fine to not support/change EntitySourceDefinitionsLegacyRepoSettingsParser (as that is not the default any more and will be removed soon)

Event Timeline

Change 612630 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: Initialize entitysource defaults

Change 612630 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Initialize entitysource defaults

Resolved as it's in the Done column at the end of sprint 3 (start of sprint 4)

Change 666611 had a related patch set uploaded (by Hoo man; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@REL1_35] Backport five FP changes

Change 666611 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@REL1_35] Backport five FP changes