Page MenuHomePhabricator
Create Task
Maniphest T257911

Rename "whitelist" and "blacklist" terms used throughout the codebase and documentation
Closed, ResolvedPublic
Actions

Description

In line with recent awareness and trends, and with a similar discussion in T254646 I'd like to propose renaming the terms "whitelist" and "blacklist" which are used extensively in this project and in relevant documentation.

Alternatives to consider might be "ignore-list" for ignored things (such as properties or items), "deny-list" for things that are actively blocked such as data from an untrusted resource, and "allow-list" for things that are actively allowed.

Related Objects
Search...

Event Timeline

ItamarWMDE created this task.Jul 14 2020, 11:43 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptJul 14 2020, 11:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ItamarWMDE moved this task from Backlog to Prioritized for sprint on the Wikidata - Reference Treasure Hunt board.Jul 15 2020, 9:14 AM
ItamarWMDE added a parent task: T254646: Reconsidering how we name things.Jul 15 2020, 9:17 AM
Tarrow subscribed.Jul 15 2020, 9:20 AM

This could even be a good time to be more specific about what they are:

  • ItemClassesToIgnore
  • PropertiesThatNeedNoReference
  • ExternalIdentifiersToIgnore

etc...

ItamarWMDE added a comment.Jul 15 2020, 9:26 AM

Agreed, which will also help alleviate some of the confusion points we ran into during development

Ladsgroup awarded a token.Jul 15 2020, 9:41 AM
ItamarWMDE claimed this task.Jul 15 2020, 1:34 PM
darthmon_wmde awarded a token.Jul 15 2020, 1:55 PM
darthmon_wmde added subscribers: Lydia_Pintscher, darthmon_wmde.

pinging @Lydia_Pintscher, who would need to be aware of this change too :)

darthmon_wmde added a comment.Jul 15 2020, 1:57 PM
In T257911#6307705, @Tarrow wrote:

This could even be a good time to be more specific about what they are:

  • ItemClassesToIgnore
  • PropertiesThatNeedNoReference
  • ExternalIdentifiersToIgnore

etc...

I personally like the idea of being more concrete with what the lists really contain.

Lydia_Pintscher added a comment.Jul 15 2020, 1:57 PM

👍

ItamarWMDE added a comment.Jul 21 2020, 8:52 AM

Ready for review:

Codebase:

Data:

ItamarWMDE closed this task as Resolved.Jul 21 2020, 9:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL