| taavi | |
| Jul 14 2020, 12:10 PM |
| F31934989: image.png | |
| Jul 14 2020, 12:10 PM |
See https://www.mediawiki.org/wiki/Project:Sandbox for example:
That page says:
Retrieved from "https://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=3963051"
That should be only visible on the printable view. On wmf.41 vector it is visible everywhere
That text appears to be just plain text just before category links inside #bodyContent
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | Jdforrester-WMF | T256669 1.35.0-wmf.41 deployment blockers | ||
| Resolved | DannyS712 | T257914 Vector now shows printfooter on all page views |
Probably related to the Desktop Improvements work? I vaguely recall seeing something about refactoring printable mode?
Change 612490 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/skins/Vector@master] Restore div wrapper around print footer
Change 612490 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Restore div wrapper around print footer
Change 612495 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/skins/Vector@wmf/1.35.0-wmf.41] Restore div wrapper around print footer
Change 612496 had a related patch set uploaded (by Jforrester; owner: DannyS712):
[mediawiki/skins/Vector@REL1_35] Restore div wrapper around print footer
Change 612496 merged by jenkins-bot:
[mediawiki/skins/Vector@REL1_35] Restore div wrapper around print footer
Change 612495 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.35.0-wmf.41] Restore div wrapper around print footer
Mentioned in SAL (#wikimedia-operations) [2020-07-14T14:57:15Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.41/skins/Vector/includes/SkinVector.php: T257914 Restore div wrapper around print footer (duration: 01m 03s)
...was a train blocker, unbreak now was the correct priority - usually not lowered afterwards
Thank you.
Also, train blockers should not be marked fixed except by the train conductor when code is deployed.