Page MenuHomePhabricator

Vector now shows printfooter on all page views
Closed, ResolvedPublic

Description

See https://www.mediawiki.org/wiki/Project:Sandbox for example:

That page says:

Retrieved from "https://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=3963051"

That should be only visible on the printable view. On wmf.41 vector it is visible everywhere

That text appears to be just plain text just before category links inside #bodyContent

Event Timeline

Majavah triaged this task as Unbreak Now! priority.Jul 14 2020, 12:10 PM
Majavah created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2020, 12:10 PM
Majavah updated the task description. (Show Details)Jul 14 2020, 12:12 PM
Majavah added a project: Readers-Web-Backlog.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Probably related to the Desktop Improvements work? I vaguely recall seeing something about refactoring printable mode?

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJul 14 2020, 12:25 PM

Change 612490 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/skins/Vector@master] Restore div wrapper around print footer

https://gerrit.wikimedia.org/r/612490

Change 612490 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Restore div wrapper around print footer

https://gerrit.wikimedia.org/r/612490

Change 612495 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/skins/Vector@wmf/1.35.0-wmf.41] Restore div wrapper around print footer

https://gerrit.wikimedia.org/r/612495

Change 612496 had a related patch set uploaded (by Jforrester; owner: DannyS712):
[mediawiki/skins/Vector@REL1_35] Restore div wrapper around print footer

https://gerrit.wikimedia.org/r/612496

Change 612496 merged by jenkins-bot:
[mediawiki/skins/Vector@REL1_35] Restore div wrapper around print footer

https://gerrit.wikimedia.org/r/612496

Change 612495 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.35.0-wmf.41] Restore div wrapper around print footer

https://gerrit.wikimedia.org/r/612495

Ammarpad renamed this task from Vector now shows "Retrieved from "https://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=3963051"" on all page views to Vector now shows printfooter on all page views.Jul 14 2020, 2:56 PM
Ammarpad closed this task as Resolved.
Ammarpad lowered the priority of this task from Unbreak Now! to Medium.

Mentioned in SAL (#wikimedia-operations) [2020-07-14T14:57:15Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.41/skins/Vector/includes/SkinVector.php: T257914 Restore div wrapper around print footer (duration: 01m 03s)

DannyS712 raised the priority of this task from Medium to Unbreak Now!.Jul 14 2020, 2:57 PM

...was a train blocker, unbreak now was the correct priority - usually not lowered afterwards

Thank you.

Also, train blockers should not be marked fixed except by the train conductor when code is deployed.

Confirmed to no longer be an issue