Page MenuHomePhabricator
Create Task
Maniphest T257990

Hard deprecate Skin::setupSkinUserCss
Closed, ResolvedPublic
Actions

Description

Having this around and not throwing hard deprecation notices is confusing. This has been deprecated since 1.32

https://codesearch.wmcloud.org/search/?q=setupSkinUserCss&i=nope&files=&repos=

Details

ProjectBranchLines +/-Subject
mediawiki/coreREL1_35+89 -6Emit deprecation warning for deprecated overrides.
mediawiki/coremaster+92 -14Emit deprecation warning for deprecated overrides.
mediawiki/coremaster+11 -7Revert "Deprecate Skin::setupSkinUserCss"
mediawiki/coremaster+7 -11Deprecate Skin::setupSkinUserCss
mediawiki/skins/CologneBluemaster+14 -15Remove usage of deprecated Skin::setupSkinUserCss
mediawiki/skins/Nostalgiamaster+13 -13Remove usage of Skin::setupSkinUserCss
mediawiki/skins/Modernmaster+11 -13Modern: Remove usage of deprecated Skin::setupSkinUserCss
mediawiki/skins/Timelessmaster+0 -9Remove Skin::setupSkinUserCss call
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jul 14 2020, 10:19 PM
Jdlrobson moved this task from Phase 3 - standardise template data to Phase 2 - Deprecate and remove Skin methods for readability on the MediaWiki-Core-Skin-Architecture board.Jul 15 2020, 8:47 PM
Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).Jul 24 2020, 5:23 PM
Jdlrobson triaged this task as Medium priority.Jul 24 2020, 5:27 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Isarra added a subscriber: Isarra.Jul 24 2020, 5:57 PM

The hilarious bit here is I'm not even sure any of these skins (or othe skins I've looked at) actually use it for anything.

They basicaly all just call paren::setupSkinUserCss, and even if they have anything else in the function, it could just as easily be in initPage...

Isarra added a comment.Jul 24 2020, 5:59 PM

Pretty sure they all have it because monobook/example have/had it. Kick it out of those and the rest should follow.

Jdlrobson added a comment.Jul 24 2020, 6:45 PM

Yep :) I know I've added it in the past hahah. Will be nice to remove this confusion.

Ammarpad claimed this task.Jul 25 2020, 5:33 AM
Ammarpad added a comment.Jul 27 2020, 9:53 AM

I think we can start with hard deprecation and let the removal be in 1.37

Jdlrobson added a comment.Jul 28 2020, 1:07 AM

Sounds like a good plan!

Ammarpad renamed this task from Hard deprecate (remove?) Skin::setupSkinUserCss to Hard deprecate Skin::setupSkinUserCss.Jul 28 2020, 5:23 AM
Jdlrobson removed a project: Web-Team-Backlog (Kanbanana-FY-2020-21).Jul 28 2020, 6:24 PM
gerritbot added a comment.Aug 5 2020, 9:04 AM

Change 618498 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Modern@master] Modern: Remove usage of deprecated Skin::setupSkinUserCss

https://gerrit.wikimedia.org/r/618498

gerritbot added a project: Patch-For-Review.Aug 5 2020, 9:04 AM
gerritbot added a comment.Aug 5 2020, 9:19 AM

Change 618503 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Timeless@master] Remove Skin::setupSkinUserCss call

https://gerrit.wikimedia.org/r/618503

gerritbot added a comment.Aug 5 2020, 5:43 PM

Change 618503 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Remove Skin::setupSkinUserCss call

https://gerrit.wikimedia.org/r/618503

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 5 2020, 6:00 PM
Jdlrobson updated the task description. (Show Details)Aug 5 2020, 7:19 PM
gerritbot added a comment.Aug 6 2020, 2:55 PM

Change 618498 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Modern: Remove usage of deprecated Skin::setupSkinUserCss

https://gerrit.wikimedia.org/r/618498

Jdlrobson updated the task description. (Show Details)Aug 6 2020, 2:59 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 6 2020, 3:11 PM
gerritbot added a comment.Aug 9 2020, 12:18 AM

Change 619142 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/CologneBlue@master] Remove usage of deprecated Skin::setupSkinUserCss

https://gerrit.wikimedia.org/r/619142

gerritbot added a project: Patch-For-Review.Aug 9 2020, 12:18 AM
gerritbot added a comment.Aug 9 2020, 1:04 AM

Change 619143 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Nostalgia@master] Remove usage of Skin::setupSkinUserCss

https://gerrit.wikimedia.org/r/619143

gerritbot added a comment.Aug 9 2020, 1:05 AM

Change 619144 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate Skin::setupSkinUserCss

https://gerrit.wikimedia.org/r/619144

gerritbot added a comment.Aug 11 2020, 2:58 PM

Change 619143 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@master] Remove usage of Skin::setupSkinUserCss

https://gerrit.wikimedia.org/r/619143

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.5; 2020-08-18); removed MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 11 2020, 3:00 PM
Jdlrobson updated the task description. (Show Details)Aug 11 2020, 3:00 PM
gerritbot added a comment.Aug 11 2020, 3:01 PM

Change 619142 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] Remove usage of deprecated Skin::setupSkinUserCss

https://gerrit.wikimedia.org/r/619142

gerritbot added a comment.Aug 11 2020, 3:23 PM

Change 619144 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Skin::setupSkinUserCss

https://gerrit.wikimedia.org/r/619144

Ammarpad closed this task as Resolved.Aug 12 2020, 8:53 PM
• Demian added a subscriber: • Demian.Aug 25 2020, 10:23 AM

@Ammarpad The removal of the call to setupSkinUserCss() in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/619144/2/includes/OutputPage.php
broke many skins from the following list as these no longer load their stylesheets:
https://codesearch.wmcloud.org/search/?q=setupSkinUserCss&i=nope&files=&repos=

The deprecation warning inserted here is ineffective as the overridden methods aren't called, which in turn won't call this method.
Consequently this patch immediately removes functionality without warning, contrary to the deprecation policy.
To properly warn when a skin overrides the deprecated method reflection is necessary.
Fix: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/622254

Jdlrobson added a comment.EditedAug 26 2020, 11:17 PM

Thanks for flagging this.

According to https://www.mediawiki.org/wiki/Stable_interface_policy#Deprecation "Hard deprecated code MAY act as no-ops instead of actually functioning, though this is not recommended.".
This might be a case of where this case is recommended.

In this case it's obvious the functionality is broken by the failure of the stylesheet to load. That should be a sufficient enough warning IMO to a skin developer. Possibly an email to wikitech-l would also help here.

• Demian mentioned this in T266735: Fix or archive skin using deprecated Skin::setupSkinUserCss() method.Oct 29 2020, 3:05 AM
DannyS712 added a subscriber: DannyS712.Oct 31 2020, 3:15 AM
gerritbot added a comment.Nov 22 2020, 11:07 PM

Change 642847 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/core@master] Revert "Deprecate Skin::setupSkinUserCss"

https://gerrit.wikimedia.org/r/642847

Reedy reopened this task as Open.Nov 22 2020, 11:33 PM
Ammarpad removed Ammarpad as the assignee of this task.Nov 23 2020, 3:25 AM
Ammarpad added a subscriber: Ammarpad.
gerritbot added a comment.Nov 24 2020, 5:07 AM

Change 642847 merged by jenkins-bot:
[mediawiki/core@master] Revert "Deprecate Skin::setupSkinUserCss"

https://gerrit.wikimedia.org/r/642847

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.20; 2020-12-01); removed MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Nov 24 2020, 6:00 AM
Ammarpad closed this task as Resolved.Nov 24 2020, 9:59 AM
Ammarpad claimed this task.

Hard deprecated in another way

gerritbot added a comment.Dec 2 2020, 9:51 PM

Change 644931 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Emit deprecation warning for deprecated overrides.

https://gerrit.wikimedia.org/r/644931

gerritbot added a comment.Jan 13 2021, 4:06 AM

Change 644931 merged by jenkins-bot:
[mediawiki/core@master] Emit deprecation warning for deprecated overrides.

https://gerrit.wikimedia.org/r/644931

gerritbot added a comment.Jan 30 2022, 6:20 PM

Change 758097 had a related patch set uploaded (by Reedy; author: Daniel Kinzler):

[mediawiki/core@REL1_35] Emit deprecation warning for deprecated overrides.

https://gerrit.wikimedia.org/r/758097

gerritbot added a comment.Feb 24 2022, 12:36 AM

Change 758097 abandoned by Reedy:

[mediawiki/core@REL1_35] Emit deprecation warning for deprecated overrides.

Reason:

https://gerrit.wikimedia.org/r/758097

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL