Page MenuHomePhabricator
Create Task
Maniphest T257992

Hard deprecate Skin::isRevisionCurrent and Skin::getRevisionId
Closed, ResolvedPublic
Actions

Description

Both soft deprecated since 1.34
They should throw deprecation warning now

  • Fix WikibaseRepo
  • Fix Minerva
  • Hard deprecate

Details

SubjectRepoBranchLines +/-
Hard deprecate Skin::isRevisionCurrent and Skin::getRevisionIdmediawiki/coremaster+4 -0
Remove usage of deprecated Skin::getRevisionId()mediawiki/skins/MinervaNeuemaster+5 -4
Remove usage of deprecated Skin methodsmediawiki/extensions/Wikibasemaster+3 -2
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jul 14 2020, 10:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2020, 10:21 PM
Jdlrobson renamed this task from Remove Skin::isRevisionCurrent to Remove Skin::isRevisionCurrent and Skin::getRevisionId.Jul 14 2020, 10:21 PM
gerritbot added a comment.Jul 29 2020, 2:56 PM

Change 617155 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/Wikibase@master] Remove usage of deprecated Skin methods

https://gerrit.wikimedia.org/r/617155

gerritbot added a project: Patch-For-Review.Jul 29 2020, 2:56 PM
Ammarpad added projects: MediaWiki-extensions-WikibaseRepository, MinervaNeue.Jul 29 2020, 3:01 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptJul 29 2020, 3:01 PM
Ammarpad updated the task description. (Show Details)Jul 29 2020, 3:02 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJul 29 2020, 3:02 PM
Ammarpad subscribed.Jul 29 2020, 3:07 PM

They are actually being used in some few places, including Minerva skin.

gerritbot added a comment.Jul 29 2020, 3:12 PM

Change 617160 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MinervaNeue@master] Remove usage of deprecated Skin::getRevisionId()

https://gerrit.wikimedia.org/r/617160

Jdlrobson updated the task description. (Show Details)Jul 29 2020, 3:17 PM
gerritbot added a comment.Jul 29 2020, 4:01 PM

Change 617155 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove usage of deprecated Skin methods

https://gerrit.wikimedia.org/r/617155

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 29 2020, 5:00 PM
gerritbot added a comment.Jul 29 2020, 7:43 PM

Change 617160 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove usage of deprecated Skin::getRevisionId()

https://gerrit.wikimedia.org/r/617160

Jdlrobson updated the task description. (Show Details)Jul 29 2020, 7:52 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 29 2020, 8:10 PM
gerritbot added a comment.Aug 1 2020, 10:42 AM

Change 617804 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Hard deprecate Skin::isRevisionCurrent and Skin::getRevisionId

https://gerrit.wikimedia.org/r/617804

gerritbot added a project: Patch-For-Review.Aug 1 2020, 10:42 AM
gerritbot added a comment.Aug 7 2020, 3:04 PM

Change 617804 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Skin::isRevisionCurrent and Skin::getRevisionId

https://gerrit.wikimedia.org/r/617804

Maintenance_bot removed a project: Patch-For-Review.Aug 7 2020, 3:11 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.4; 2020-08-11); removed MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Aug 7 2020, 4:00 PM
Ammarpad renamed this task from Remove Skin::isRevisionCurrent and Skin::getRevisionId to Hard deprecate Skin::isRevisionCurrent and Skin::getRevisionId.Aug 7 2020, 5:58 PM
Ammarpad updated the task description. (Show Details)
Ammarpad updated the task description. (Show Details)
Ammarpad closed this task as Resolved.Aug 7 2020, 6:00 PM
Ammarpad claimed this task.
Ammarpad triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL