Page MenuHomePhabricator
Create Task
Maniphest T257996

Deprecate Skin::mainPageLink
Closed, ResolvedPublic
Actions

Description

Only CologneBlue uses this in production
This does not belong on the skin.

  • Copy Skin::mainPageLink to make it local to CologneBlue
  • Mark as deprecated.
  • Nostaglia is patched

Details

SubjectRepoBranchLines +/-
Remove usages of Skin::mainPageLink()mediawiki/skins/CologneBluemaster+20 -9
mainPageLink is deprecatedmediawiki/skins/Nostalgiawmf/1.36.0-wmf.9+11 -2
mainPageLink is deprecatedmediawiki/skins/Nostalgiawmf/1.36.0-wmf.9+14 -3
mainPageLink is deprecatedmediawiki/skins/Nostalgiamaster+11 -2
Deprecate Skin::mainPageLinkmediawiki/coremaster+5 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jul 14 2020, 10:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2020, 10:29 PM
Jdlrobson triaged this task as Medium priority.Sep 4 2020, 9:28 PM
gerritbot added a comment.Sep 7 2020, 12:39 AM

Change 625578 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/CologneBlue@master] Remove usages of Skin::mainPageLink()

https://gerrit.wikimedia.org/r/625578

gerritbot added a project: Patch-For-Review.Sep 7 2020, 12:39 AM

Change 625579 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate Skin::mainPageLink

https://gerrit.wikimedia.org/r/625579

gerritbot added a comment.Sep 9 2020, 4:33 PM

Change 625578 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] Remove usages of Skin::mainPageLink()

https://gerrit.wikimedia.org/r/625578

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 9 2020, 5:00 PM
gerritbot added a comment.Sep 9 2020, 6:09 PM

Change 625579 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Skin::mainPageLink

https://gerrit.wikimedia.org/r/625579

Maintenance_bot removed a project: Patch-For-Review.Sep 9 2020, 6:10 PM
Jdlrobson closed this task as Resolved.Sep 9 2020, 6:41 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Nostalgia, Wikimedia-production-error.Sep 15 2020, 4:37 PM

Looks like we also need to patch Nostalgia wiki which is throwing warnings in production logs.
https://nostalgia.wikipedia.org/wiki/Velocity

gerritbot added a comment.Sep 15 2020, 4:40 PM

Change 627560 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Nostalgia@master] mainPageLink is deprecated

https://gerrit.wikimedia.org/r/627560

gerritbot added a project: Patch-For-Review.Sep 15 2020, 4:40 PM
Jdlrobson reopened this task as Open.Sep 15 2020, 4:40 PM
Jdlrobson updated the task description. (Show Details)
brennen added a project: User-brennen.Sep 15 2020, 5:11 PM
brennen subscribed.

I'm currently seeing a pretty steady stream of these in production logs:

Use of Skin::aboutLink was deprecated in MediaWiki 1.36. [Called from NostalgiaTemplate::afterContent]
Use of Skin::privacyLink was deprecated in MediaWiki 1.36. [Called from NostalgiaTemplate::pageTitleLinks]
Use of Skin::disclaimerLink was deprecated in MediaWiki 1.36. [Called from NostalgiaTemplate::pageTitleLinks]

I assume this is the correct ticket for that, but please let me know if those should be filed elsewhere.

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Sep 15 2020, 5:11 PM
Jdlrobson added a comment.EditedSep 15 2020, 5:18 PM

@brennen those ones relate to https://gerrit.wikimedia.org/r/c/mediawiki/skins/Nostalgia/+/623959/2 (T258001) and have already been fixed

brennen added a comment.Sep 15 2020, 5:20 PM

those ones relate to https://gerrit.wikimedia.org/r/c/mediawiki/skins/Nostalgia/+/623959/2 (T258001) and have already been fixed

Cool, thanks.

gerritbot added a comment.Sep 15 2020, 5:59 PM

Change 627560 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@master] mainPageLink is deprecated

https://gerrit.wikimedia.org/r/627560

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.10; 2020-09-22); removed MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 15 2020, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 15 2020, 6:11 PM
Ammarpad closed this task as Resolved.Sep 15 2020, 6:14 PM
Ammarpad claimed this task.
Ammarpad updated the task description. (Show Details)
Krinkle mentioned this in T258001: Deprecate Skin methods that are aliases for footerLink.Sep 15 2020, 7:50 PM
gerritbot added a comment.Sep 15 2020, 8:21 PM

Change 627460 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Nostalgia@wmf/1.36.0-wmf.9] mainPageLink is deprecated

https://gerrit.wikimedia.org/r/627460

gerritbot added a project: Patch-For-Review.Sep 15 2020, 8:21 PM
gerritbot added a comment.Sep 15 2020, 8:46 PM

Change 627460 abandoned by Jdlrobson:
[mediawiki/skins/Nostalgia@wmf/1.36.0-wmf.9] mainPageLink is deprecated

Reason:

https://gerrit.wikimedia.org/r/627460

gerritbot added a comment.Sep 15 2020, 8:49 PM

Change 627596 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Nostalgia@wmf/1.36.0-wmf.9] mainPageLink is deprecated

https://gerrit.wikimedia.org/r/627596

gerritbot added a comment.Sep 15 2020, 8:58 PM

Change 627596 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@wmf/1.36.0-wmf.9] mainPageLink is deprecated

https://gerrit.wikimedia.org/r/627596

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.9; 2020-09-15); removed MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 15 2020, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL