Page MenuHomePhabricator
Create Task
Maniphest T258001

Deprecate Skin methods that are aliases for footerLink
Closed, ResolvedPublic
Actions

Description

These are all wrappers for the method footerLink and tend to be used by legacy skins.
https://codesearch.wmcloud.org/search/?q=aboutLink%5C(&i=nope&files=&repos=
https://codesearch.wmcloud.org/search/?q=disclaimerLink%5C(&i=nope&files=&repos=
https://codesearch.wmcloud.org/search/?q=privacyLink\(&i=nope&files=&repos=

  • OAuth Extension has been updated
  • CologneBlue has been updated
  • aboutLink is deprecated with a note to use footerLink instead
  • disclaimerLink is deprecated with a note to use footerLink instead
  • privacyLink is deprecated with a note to use footerLink instead
  • The docblock for footerLink documents the supported values

Not blocking completion of this task:

  • Nimbus, Nostalgia and BlueSpiceCalumma have patches

Details

SubjectRepoBranchLines +/-
Remove usage of Skin::aboutLink()mediawiki/skins/Nimbusmaster+17 -6
Remove site footer links indirectionmediawiki/skins/Nostalgiawmf/1.36.0-wmf.9+3 -3
Remove site footer links indirectionmediawiki/skins/Nostalgiamaster+3 -3
Remove skin footer links indirectionmediawiki/skins/BlueSpiceCalummamaster+4 -3
Remove skin footer links indirectionmediawiki/skins/BlueSpiceCalummaREL1_35+4 -3
Deprecate Skin methods that are aliases for footerLinkmediawiki/coremaster+31 -8
Remove usage of Skin::aboutLink()mediawiki/skins/CologneBluemaster+4 -3
Remove site privacy link indirectionmediawiki/extensions/OAuthmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jul 14 2020, 11:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2020, 11:30 PM
Ammarpad claimed this task.Jul 15 2020, 9:01 AM
Ammarpad triaged this task as Medium priority.Aug 27 2020, 12:17 PM
Ammarpad added projects: MediaWiki-extensions-OAuth, CologneBlue, Nostalgia.
gerritbot added a comment.Aug 27 2020, 4:21 PM

Change 622847 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/OAuth@master] Remove site privacy link indirection

https://gerrit.wikimedia.org/r/622847

gerritbot added a project: Patch-For-Review.Aug 27 2020, 4:21 PM
gerritbot added a comment.Aug 27 2020, 7:20 PM

Change 622847 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Remove site privacy link indirection

https://gerrit.wikimedia.org/r/622847

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Aug 27 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 27 2020, 8:10 PM
Jdlrobson removed a project: MediaWiki-extensions-OAuth.Aug 31 2020, 5:00 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Sep 2 2020, 7:11 PM

Change 623563 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/BlueSpiceCalumma@master] Remove skin footer links indirection

https://gerrit.wikimedia.org/r/623563

gerritbot added a project: Patch-For-Review.Sep 2 2020, 7:11 PM
gerritbot added a comment.Sep 2 2020, 7:17 PM

Change 623854 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/CologneBlue@master] Remove usage of Skin::aboutLink()

https://gerrit.wikimedia.org/r/623854

Jdlrobson removed a project: CologneBlue.Sep 2 2020, 9:38 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Sep 2 2020, 9:48 PM

Change 623854 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] Remove usage of Skin::aboutLink()

https://gerrit.wikimedia.org/r/623854

gerritbot added a comment.Sep 3 2020, 8:19 AM

Change 623959 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Nostalgia@master] Remove site footer links indirection

https://gerrit.wikimedia.org/r/623959

gerritbot added a comment.Sep 3 2020, 5:49 PM

Change 623903 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Nimbus@master] Bug: T258001

https://gerrit.wikimedia.org/r/623903

gerritbot added a comment.Sep 3 2020, 5:57 PM

Change 623903 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Nimbus@master] Remove usage of Skin::aboutLink()

https://gerrit.wikimedia.org/r/623903

gerritbot added a comment.Sep 3 2020, 7:35 PM

Change 624235 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate Skin methods that are aliases for footerLink

https://gerrit.wikimedia.org/r/624235

gerritbot added a comment.Sep 3 2020, 9:50 PM

Change 624235 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Skin methods that are aliases for footerLink

https://gerrit.wikimedia.org/r/624235

Jdlrobson closed this task as Resolved.Sep 3 2020, 10:02 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Sep 4 2020, 11:44 AM

Change 624296 had a related patch set uploaded (by Robert Vogel; owner: Ammarpad):
[mediawiki/skins/BlueSpiceCalumma@REL1_35] Remove skin footer links indirection

https://gerrit.wikimedia.org/r/624296

gerritbot added a comment.Sep 4 2020, 11:48 AM

Change 624296 merged by jenkins-bot:
[mediawiki/skins/BlueSpiceCalumma@REL1_35] Remove skin footer links indirection

https://gerrit.wikimedia.org/r/624296

Osnard mentioned this in rMSBC7f548cd5fa38: Remove skin footer links indirection.Sep 4 2020, 11:48 AM
gerritbot added a comment.Sep 4 2020, 11:49 AM

Change 623563 merged by jenkins-bot:
[mediawiki/skins/BlueSpiceCalumma@master] Remove skin footer links indirection

https://gerrit.wikimedia.org/r/623563

Ammarpad mentioned this in rMSBCe52ac593baa9: Remove skin footer links indirection.Sep 4 2020, 11:50 AM
gerritbot added a comment.Sep 15 2020, 4:45 PM

Change 623959 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@master] Remove site footer links indirection

https://gerrit.wikimedia.org/r/623959

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.10; 2020-09-22); removed MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 15 2020, 5:00 PM
Jdlrobson mentioned this in T257996: Deprecate Skin::mainPageLink.Sep 15 2020, 5:18 PM
brennen added a project: User-brennen.Sep 15 2020, 5:20 PM
brennen moved this task from Backlog to Logs/Train on the User-brennen board.
Krinkle reopened this task as Open.EditedSep 15 2020, 7:49 PM
Krinkle added a parent task: T257977: 1.36.0-wmf.9 deployment blockers.
Krinkle subscribed.
In T257996#6463522, @brennen wrote:

I'm currently seeing a pretty steady stream of these in production logs:

Use of Skin::aboutLink was deprecated in MediaWiki 1.36. [Called from NostalgiaTemplate::afterContent]
Use of Skin::privacyLink was deprecated in MediaWiki 1.36. [Called from NostalgiaTemplate::pageTitleLinks]
Use of Skin::disclaimerLink was deprecated in MediaWiki 1.36. [Called from NostalgiaTemplate::pageTitleLinks]

I assume this is the correct ticket for that, but please let me know if those should be filed elsewhere.

Awaiting backport. Prod errors are notably raised drowning out smaller regressions.

Krinkle added a subscriber: brennen.Sep 15 2020, 7:50 PM
RhinosF1 raised the priority of this task from Medium to Unbreak Now!.Sep 15 2020, 8:05 PM
RhinosF1 subscribed.

Train blocker --> UBN!

gerritbot added a comment.Sep 15 2020, 8:20 PM

Change 627459 had a related patch set uploaded (by Jdlrobson; owner: Ammarpad):
[mediawiki/skins/Nostalgia@wmf/1.36.0-wmf.9] Remove site footer links indirection

https://gerrit.wikimedia.org/r/627459

gerritbot added a comment.Sep 15 2020, 8:37 PM

Change 627459 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@wmf/1.36.0-wmf.9] Remove site footer links indirection

https://gerrit.wikimedia.org/r/627459

Jdlrobson closed this task as Resolved.Sep 15 2020, 8:39 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.9; 2020-09-15); removed MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 15 2020, 9:00 PM
brennen mentioned this in T257977: 1.36.0-wmf.9 deployment blockers.Sep 15 2020, 10:28 PM
Mainframe98 mentioned this in T263020: Use of Skin::aboutLink was deprecated in MediaWiki 1.36. [Called from NostalgiaTemplate::afterContent].Sep 16 2020, 3:00 PM
gerritbot added a comment.Nov 7 2020, 5:01 AM

Change 623903 abandoned by Ammarpad:
[mediawiki/skins/Nimbus@master] Remove usage of Skin::aboutLink()

Reason:
obsolote

https://gerrit.wikimedia.org/r/623903

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL