Page MenuHomePhabricator
Create Task
Maniphest T258011

Mobile paragraph hoisting not working on haw.wikipedia.org
Closed, ResolvedPublic
Actions

Description

Example at https://haw.m.wikipedia.org/wiki/Olakino:

capture.png (1×818 px, 139 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Apply mobile width fixes to infoboxes explicitlymediawiki/skins/MinervaNeuemaster+3 -1
Apply infobox styles to any element with the classmediawiki/skins/MinervaNeuemaster+55 -51
Customize query in gerrit

Related Objects

Event Timeline

• Krinkle created this task.Jul 15 2020, 1:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2020, 1:17 AM
Ammarpad mentioned this in T258201: MoveLeadParagraphTransformInfobox re-order should apply other floated elements, e.g. images.Jul 16 2020, 5:14 PM
Esanders subscribed.Jul 17 2020, 11:03 AM

The {{databox}} template on that wiki needs the "infobox" class, as this is what MobileFrontend uses to detect.

Esanders added a comment.Jul 17 2020, 11:17 AM

I added the infobox class which hoists the paragraph. Apparently div.infobox doesn't go full width, only table.infobox.

gerritbot added a comment.Jul 17 2020, 6:04 PM

Change 613663 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] Apply infobox styles to div's as well as table's

https://gerrit.wikimedia.org/r/613663

gerritbot added a project: Patch-For-Review.Jul 17 2020, 6:04 PM
gerritbot added a comment.Jul 17 2020, 9:27 PM

Change 613722 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] Apply mobile width fixes to infoboxes explicitly

https://gerrit.wikimedia.org/r/613722

Jdlrobson edited projects, added Web-Team-Backlog-Archived (Kanbanana-FY-2020-21); removed Web-Team-Backlog-Archived.Jul 20 2020, 5:04 PM
Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Jul 23 2020, 3:36 PM
gerritbot added a comment.Jul 24 2020, 12:40 AM

Change 613663 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Apply infobox styles to any element with the class

https://gerrit.wikimedia.org/r/613663

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 24 2020, 1:00 AM
gerritbot added a comment.Jul 24 2020, 4:11 PM

Change 613722 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Apply mobile width fixes to infoboxes explicitly

https://gerrit.wikimedia.org/r/613722

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2020, 5:10 PM
Jdlrobson moved this task from Needs More Work to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Jul 27 2020, 5:10 PM
ovasileva closed this task as Resolved.Aug 31 2020, 11:58 AM
ovasileva claimed this task.
ovasileva subscribed.

Looks good, resolving!

Screen Shot 2020-08-31 at 1.57.45 PM.png (1×998 px, 99 KB)

Jdlrobson moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Sep 3 2020, 9:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits