Page MenuHomePhabricator
Create Task
Maniphest T258044

Measure the difference in performance loading large item pages and history pages before and after prefetching
Closed, ResolvedPublic
Actions

Description

Should only be done after the main parts of T254740 are done.

An idea about some tech to maybe do this with is mentioned in T258044#6311426 (jmeter)

For item loading:

  • A page with statements with 51 different properties?

For history loading:

  • A history page with summaries that refer to 51 different properties?

Rough Steps:

  • Run a version of the code without the prefetching
  • Load some pages and get timing data for full page load from the browser
  • Run a version of the code with all the prefetching
  • Load some pages and get timing data for full page load from the browser
  • Report finding here

Related Objects
Search...

Event Timeline

Addshore created this task.Jul 15 2020, 10:56 AM
Addshore moved this task from Backlog to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.
Silvan_WMDE added subscribers: Tarrow, Silvan_WMDE.Jul 16 2020, 9:06 AM

There were some helpful remarks on this topic from @Tarrow in the navigators summit:

There is the jmeter thing in the base on wikibase.git that might be useful for this. Locust (a different thing) used for termbox a bit. The dream was to have something like T230530 but we used locust on a developer laptop in the end. Detailed docs for termbox loadtesting are at: https://gerrit.wikimedia.org/r/plugins/gitiles/wikibase/termbox/+/refs/heads/master/infrastructure/load_testing/

Addshore updated the task description. (Show Details)Jul 16 2020, 9:58 AM
Addshore moved this task from Prioritized backlog (aka Ready to pick up) to Sprint 4/6 (Hike 2) on the Wikibase - Federated Properties board.Aug 17 2020, 9:09 AM
Addshore edited projects, added Wikibase - Federated Properties (Sprint 4/6 (Hike 2)); removed Wikibase - Federated Properties.
• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Sprint 5/6 (Hike 2)); removed Wikibase - Federated Properties (Sprint 4/6 (Hike 2)).Aug 19 2020, 8:38 AM
• toan claimed this task.Aug 20 2020, 12:58 PM
• toan moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.
• toan added a comment.Aug 20 2020, 1:36 PM

This item could be used:

https://wikidata-federated-properties.wmflabs.org/wiki/Item:Q32

Setup with a simple maintenance script found in:

/home/toan/populateData.php on the test system

• toan added a comment.Aug 20 2020, 1:48 PM

Requesting https://wikidata-federated-properties.wmflabs.org/wiki/Item:Q32 takes currently 14 seconds

• toan added a comment.EditedAug 21 2020, 9:00 AM

Tried out using a configured version of the mentioned locust setup but feels this is currently not viable to get any meaningful results.

Running it without prefetching against our test system with only 10 users spawning every 1 second results in very interesting behavior where the page loads eventually become to high resulting in wdqs-updater not being able to reach the website and then crashing and restarting over and over again resulting in a very random looking chart.

• toan added a comment.EditedAug 25 2020, 9:52 AM

Ok this is new new and shiny item used for testing -> https://wikidata-federated-properties.wmflabs.org/w/index.php?title=Item:Q34

History-page: 14 seconds
Item-page: 9 seconds
Recent-changes: 10 seconds

using mod-header set X-FedProps-SourceApiResponse = 200 to skip the parser-cache.

Addshore added a comment.EditedAug 27 2020, 11:41 AM

While loading for me I now see using mod-header set X-FedProps-SourceApiResponse = 200 to skip the parser-cache.

History-page: 8 seconds
Item-page: 8 seconds
Recent-changes: 8 seconds

Addshore added a comment.Sep 1 2020, 12:09 PM

I believe everything is merged now, testing I get:

History-page: ~ 1 second
Item-page: less than 1 second
Recent-changes: ~ 1 second too

Addshore moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.Sep 1 2020, 12:12 PM
Addshore moved this task from Peer Review to Product Verification on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.
• toan added a comment.Sep 1 2020, 1:15 PM

History-page: 1.65s
Item-page: 1.72 s
Recent-changes: 1.96,

however this is with all js and stuff. Initial page-load seems to be a bit less than 1 second on all three without parser cache.

Addshore added a comment.Sep 1 2020, 4:19 PM
In T258044#6426743, @toan wrote:

however this is with all js and stuff. Initial page-load seems to be a bit less than 1 second on all three without parser cache.

My numbers are only counting the initial page load

• Samantha_Alipio_WMDE moved this task from Product Verification to Done on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.Sep 2 2020, 1:05 PM
• Samantha_Alipio_WMDE closed this task as Resolved.Sep 4 2020, 10:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits